From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com,
Bruce Richardson <bruce.richardson@intel.com>,
Ian Stokes <ian.stokes@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Praveen Shetty <praveen.shetty@intel.com>
Subject: [PATCH v4 02/11] net/intel: use common AVX build code
Date: Wed, 19 Mar 2025 17:29:32 +0000 [thread overview]
Message-ID: <20250319172942.2992053-3-bruce.richardson@intel.com> (raw)
In-Reply-To: <20250319172942.2992053-1-bruce.richardson@intel.com>
Remove driver-specific build instructions for the AVX2 and AVX-512 code,
and rely instead on the generic driver build file.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/intel/i40e/meson.build | 26 ++------------------------
drivers/net/intel/iavf/meson.build | 25 ++-----------------------
drivers/net/intel/ice/meson.build | 25 ++-----------------------
drivers/net/intel/idpf/meson.build | 25 ++-----------------------
4 files changed, 8 insertions(+), 93 deletions(-)
diff --git a/drivers/net/intel/i40e/meson.build b/drivers/net/intel/i40e/meson.build
index 15993393fb..dae61222cf 100644
--- a/drivers/net/intel/i40e/meson.build
+++ b/drivers/net/intel/i40e/meson.build
@@ -40,31 +40,9 @@ includes += include_directories('base')
if arch_subdir == 'x86'
sources += files('i40e_rxtx_vec_sse.c')
+ sources_avx2 += files('i40e_rxtx_vec_avx2.c')
+ sources_avx512 += files('i40e_rxtx_vec_avx512.c')
- i40e_avx2_lib = static_library('i40e_avx2_lib',
- 'i40e_rxtx_vec_avx2.c',
- dependencies: [static_rte_ethdev, static_rte_kvargs, static_rte_hash],
- include_directories: includes,
- c_args: [cflags, cc_avx2_flags])
- objs += i40e_avx2_lib.extract_objects('i40e_rxtx_vec_avx2.c')
-
- if cc_has_avx512
- cflags += ['-DCC_AVX512_SUPPORT']
- avx512_args = cflags + cc_avx512_flags
- if cc.has_argument('-march=skylake-avx512')
- avx512_args += '-march=skylake-avx512'
- if cc.has_argument('-Wno-overriding-option')
- avx512_args += '-Wno-overriding-option'
- endif
- endif
- i40e_avx512_lib = static_library('i40e_avx512_lib',
- 'i40e_rxtx_vec_avx512.c',
- dependencies: [static_rte_ethdev,
- static_rte_kvargs, static_rte_hash],
- include_directories: includes,
- c_args: avx512_args)
- objs += i40e_avx512_lib.extract_objects('i40e_rxtx_vec_avx512.c')
- endif
elif arch_subdir == 'ppc'
sources += files('i40e_rxtx_vec_altivec.c')
elif arch_subdir == 'arm'
diff --git a/drivers/net/intel/iavf/meson.build b/drivers/net/intel/iavf/meson.build
index 833a63e6c8..1ca500c43c 100644
--- a/drivers/net/intel/iavf/meson.build
+++ b/drivers/net/intel/iavf/meson.build
@@ -28,30 +28,9 @@ includes += include_directories('base')
if arch_subdir == 'x86'
sources += files('iavf_rxtx_vec_sse.c')
+ sources_avx2 += files('iavf_rxtx_vec_avx2.c')
+ sources_avx512 += files('iavf_rxtx_vec_avx512.c')
- iavf_avx2_lib = static_library('iavf_avx2_lib',
- 'iavf_rxtx_vec_avx2.c',
- dependencies: [static_rte_ethdev],
- include_directories: includes,
- c_args: [cflags, cc_avx2_flags])
- objs += iavf_avx2_lib.extract_objects('iavf_rxtx_vec_avx2.c')
-
- if cc_has_avx512
- cflags += ['-DCC_AVX512_SUPPORT']
- avx512_args = cflags + cc_avx512_flags
- if cc.has_argument('-march=skylake-avx512')
- avx512_args += '-march=skylake-avx512'
- if cc.has_argument('-Wno-overriding-option')
- avx512_args += '-Wno-overriding-option'
- endif
- endif
- iavf_avx512_lib = static_library('iavf_avx512_lib',
- 'iavf_rxtx_vec_avx512.c',
- dependencies: [static_rte_ethdev],
- include_directories: includes,
- c_args: avx512_args)
- objs += iavf_avx512_lib.extract_objects('iavf_rxtx_vec_avx512.c')
- endif
elif arch_subdir == 'arm'
sources += files('iavf_rxtx_vec_neon.c')
endif
diff --git a/drivers/net/intel/ice/meson.build b/drivers/net/intel/ice/meson.build
index 4d8f71cd4a..fa6c505450 100644
--- a/drivers/net/intel/ice/meson.build
+++ b/drivers/net/intel/ice/meson.build
@@ -34,30 +34,9 @@ endif
if arch_subdir == 'x86'
sources += files('ice_rxtx_vec_sse.c')
+ sources_avx2 += files('ice_rxtx_vec_avx2.c')
+ sources_avx512 += files('ice_rxtx_vec_avx512.c')
- ice_avx2_lib = static_library('ice_avx2_lib',
- 'ice_rxtx_vec_avx2.c',
- dependencies: [static_rte_ethdev, static_rte_hash],
- include_directories: includes,
- c_args: [cflags, cc_avx2_flags])
- objs += ice_avx2_lib.extract_objects('ice_rxtx_vec_avx2.c')
-
- if cc_has_avx512
- cflags += ['-DCC_AVX512_SUPPORT']
- avx512_args = cflags + cc_avx512_flags
- if cc.has_argument('-march=skylake-avx512')
- avx512_args += '-march=skylake-avx512'
- if cc.has_argument('-Wno-overriding-option')
- avx512_args += '-Wno-overriding-option'
- endif
- endif
- ice_avx512_lib = static_library('ice_avx512_lib',
- 'ice_rxtx_vec_avx512.c',
- dependencies: [static_rte_ethdev, static_rte_hash],
- include_directories: includes,
- c_args: avx512_args)
- objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c')
- endif
endif
sources += files(
diff --git a/drivers/net/intel/idpf/meson.build b/drivers/net/intel/idpf/meson.build
index 4b272d02b1..f579ffae46 100644
--- a/drivers/net/intel/idpf/meson.build
+++ b/drivers/net/intel/idpf/meson.build
@@ -19,29 +19,8 @@ sources = files(
)
if arch_subdir == 'x86' and dpdk_conf.get('RTE_IOVA_IN_MBUF') == 1
- idpf_avx2_lib = static_library('idpf_avx2_lib',
- 'idpf_common_rxtx_avx2.c',
- dependencies: [static_rte_ethdev, static_rte_hash],
- include_directories: includes,
- c_args: [cflags, cc_avx2_flags])
- objs += idpf_avx2_lib.extract_objects('idpf_common_rxtx_avx2.c')
-
- if cc_has_avx512
- cflags += ['-DCC_AVX512_SUPPORT']
- avx512_args = cflags + cc_avx512_flags
- if cc.has_argument('-march=skylake-avx512')
- avx512_args += '-march=skylake-avx512'
- if cc.has_argument('-Wno-overriding-option')
- avx512_args += '-Wno-overriding-option'
- endif
- endif
- idpf_common_avx512_lib = static_library('idpf_common_avx512_lib',
- 'idpf_common_rxtx_avx512.c',
- dependencies: static_rte_mbuf,
- include_directories: includes,
- c_args: avx512_args)
- objs += idpf_common_avx512_lib.extract_objects('idpf_common_rxtx_avx512.c')
- endif
+ sources_avx2 += files('idpf_common_rxtx_avx2.c')
+ sources_avx512 += files('idpf_common_rxtx_avx512.c')
endif
subdir('base')
--
2.43.0
next prev parent reply other threads:[~2025-03-19 17:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 17:23 [PATCH 0/3] remove driver-specific logic for AVX builds Bruce Richardson
2025-03-14 17:23 ` [PATCH 1/3] build: add generalized AVX handling for drivers Bruce Richardson
2025-03-14 17:23 ` [PATCH 2/3] net/intel: use common AVX build code Bruce Richardson
2025-03-14 17:23 ` [PATCH 3/3] drivers/net: build use common AVX handling Bruce Richardson
2025-03-14 17:31 ` David Marchand
2025-03-14 17:37 ` Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 0/4] remove driver-specific logic for AVX builds Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 1/4] build: add generalized AVX handling for drivers Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 2/4] net/intel: use common AVX build code Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 3/4] drivers/net: build use common AVX handling Bruce Richardson
2025-03-14 17:44 ` [PATCH v2 4/4] drivers/net: remove AVX2 build-time define Bruce Richardson
2025-03-17 9:47 ` David Marchand
2025-03-17 9:50 ` [PATCH v2 0/4] remove driver-specific logic for AVX builds David Marchand
2025-03-18 11:51 ` Bruce Richardson
2025-03-18 17:34 ` [PATCH v3 00/11] remove component-specific " Bruce Richardson
2025-03-18 17:34 ` [PATCH v3 01/11] build: add generalized AVX handling for drivers Bruce Richardson
2025-03-18 17:34 ` [PATCH v3 02/11] net/intel: use common AVX build code Bruce Richardson
2025-03-19 10:11 ` David Marchand
2025-03-19 11:17 ` Bruce Richardson
2025-03-18 17:34 ` [PATCH v3 03/11] drivers/net: build use common AVX handling Bruce Richardson
2025-03-18 17:34 ` [PATCH v3 04/11] drivers/net: remove AVX2 build-time define Bruce Richardson
2025-03-18 17:42 ` Ajit Khaparde
2025-03-18 17:34 ` [PATCH v3 05/11] event/dlb2: build using common AVX handling Bruce Richardson
2025-03-18 17:34 ` [PATCH v3 06/11] build: add generalized AVX handling for libs Bruce Richardson
2025-03-18 17:35 ` [PATCH v3 07/11] acl: use common AVX build handling Bruce Richardson
2025-03-19 10:16 ` David Marchand
2025-03-19 10:26 ` Bruce Richardson
2025-03-19 10:40 ` David Marchand
2025-03-19 10:59 ` Bruce Richardson
2025-03-18 17:35 ` [PATCH v3 08/11] fib: " Bruce Richardson
2025-03-18 17:35 ` [PATCH v3 09/11] net: simplify build-time logic for x86 Bruce Richardson
2025-03-19 10:24 ` David Marchand
2025-03-18 17:35 ` [PATCH v3 10/11] net: use common AVX512 build code Bruce Richardson
2025-03-18 17:35 ` [PATCH v3 11/11] member: use common AVX512 build support Bruce Richardson
2025-03-19 10:27 ` [PATCH v3 00/11] remove component-specific logic for AVX builds David Marchand
2025-03-19 17:29 ` [PATCH v4 " Bruce Richardson
2025-03-19 17:29 ` [PATCH v4 01/11] drivers: add generalized AVX build handling Bruce Richardson
2025-03-19 17:29 ` Bruce Richardson [this message]
2025-03-19 17:29 ` [PATCH v4 03/11] drivers/net: build use common AVX handling Bruce Richardson
2025-03-19 17:29 ` [PATCH v4 04/11] drivers/net: remove AVX2 build-time define Bruce Richardson
2025-03-19 17:29 ` [PATCH v4 05/11] event/dlb2: build using common AVX handling Bruce Richardson
2025-03-19 17:29 ` [PATCH v4 06/11] lib: add generalized AVX build handling Bruce Richardson
2025-03-19 17:29 ` [PATCH v4 07/11] acl: use common " Bruce Richardson
2025-03-19 17:29 ` [PATCH v4 08/11] fib: " Bruce Richardson
2025-03-19 17:29 ` [PATCH v4 09/11] net: simplify build-time logic for x86 Bruce Richardson
2025-03-19 17:29 ` [PATCH v4 10/11] net: use common AVX512 build code Bruce Richardson
2025-03-19 17:29 ` [PATCH v4 11/11] member: use common AVX512 build support Bruce Richardson
2025-03-19 18:08 ` [PATCH v4 00/11] remove component-specific logic for AVX builds Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319172942.2992053-3-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=jingjing.wu@intel.com \
--cc=praveen.shetty@intel.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).