From: Stephen Hemminger <stephen@networkplumber.org>
To: Shaokai Zhang <felix.zhang@jaguarmicro.com>
Cc: dev@dpdk.org, linville@tuxdriver.com, stable@dpdk.org,
Joey Xing <joey.xing@jaguarmicro.com>
Subject: Re: [PATCH v2 1/1] net/af_packet: register supported param fanout mode
Date: Thu, 20 Mar 2025 10:45:55 -0700 [thread overview]
Message-ID: <20250320104555.476b834e@hermes.local> (raw)
In-Reply-To: <20250320083707.5594-2-felix.zhang@jaguarmicro.com>
On Thu, 20 Mar 2025 16:37:07 +0800
Shaokai Zhang <felix.zhang@jaguarmicro.com> wrote:
> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
> index ab34285ed9..55171944cc 100644
> --- a/drivers/net/af_packet/rte_eth_af_packet.c
> +++ b/drivers/net/af_packet/rte_eth_af_packet.c
> @@ -1172,6 +1172,11 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
> PMD_LOG(INFO, "%s:\tblock count %d", name, blockcount);
> PMD_LOG(INFO, "%s:\tframe size %d", name, framesize);
> PMD_LOG(INFO, "%s:\tframe count %d", name, framecount);
> + PMD_LOG(INFO, "%s:\tqdisc bypass %d", name, qdisc_bypass);
> + if (fanout_mode)
> + PMD_LOG(INFO, "%s:\tfanout mode %s", name, fanout_mode);
> + else
> + PMD_LOG(INFO, "%s:\tfanout mode %s", name, "default PACKET_FANOUT_HASH")
All these debug messages are too noisy for my taste.
Should all be removed or made DEBUG level.
There is no point in echoing the arguments in a working driver.
next prev parent reply other threads:[~2025-03-20 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 8:15 [PATCH] " Shaokai Zhang
2025-03-20 8:37 ` [PATCH v2 0/1] " Shaokai Zhang
2025-03-20 8:37 ` [PATCH v2 1/1] " Shaokai Zhang
2025-03-20 17:45 ` Stephen Hemminger [this message]
2025-03-21 3:05 ` [PATCH v3 0/1] " Shaokai Zhang
2025-03-21 3:05 ` [PATCH v3 1/1] " Shaokai Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320104555.476b834e@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=felix.zhang@jaguarmicro.com \
--cc=joey.xing@jaguarmicro.com \
--cc=linville@tuxdriver.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).