From: Raslan Darawsheh <rasland@nvidia.com>
To: <thomas@monjalon.net>
Cc: <dev@dpdk.org>, <mb@smartsharesystems.com>,
<stephen@networkplumber.org>, <haijie1@huawei.com>
Subject: [PATCH v2] app/testpmd: fix VLAN header parsing
Date: Mon, 24 Mar 2025 10:50:23 +0200 [thread overview]
Message-ID: <20250324085023.23721-1-rasland@nvidia.com> (raw)
In-Reply-To: <20250323122822.90407-1-rasland@nvidia.com>
When processing VLAN or QinQ packets, an infinite loop occurred,
preventing the csum forward engine from proceeding and causing
testpmd to hang during shutdown attempts.
Updated the `get_ethertype_by_ptype` function to correctly parse
VLAN headers.
Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API")
Cc: haijie1@huawei.com
Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
v2: update commit log
fixed pointer handling to actually move the pointer
---
app/test-pmd/csumonly.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index 5b906eaa53..7bd1040c72 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -486,10 +486,11 @@ get_ethertype_by_ptype(struct rte_ether_hdr *eth_hdr, uint32_t ptype)
return _htons(RTE_ETHER_TYPE_IPV6);
default:
ethertype = eth_hdr->ether_type;
- while (eth_hdr->ether_type == _htons(RTE_ETHER_TYPE_VLAN) ||
- eth_hdr->ether_type == _htons(RTE_ETHER_TYPE_QINQ)) {
- vlan_hdr = (struct rte_vlan_hdr *)
- ((char *)eth_hdr + sizeof(*eth_hdr));
+ vlan_hdr = (struct rte_vlan_hdr *) RTE_PTR_ADD(eth_hdr,
+ offsetof(struct rte_ether_hdr, ether_type));
+ while ((ethertype == _htons(RTE_ETHER_TYPE_VLAN) ||
+ ethertype == _htons(RTE_ETHER_TYPE_QINQ))) {
+ vlan_hdr++;
ethertype = vlan_hdr->eth_proto;
}
return ethertype;
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-03-24 8:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 12:28 [PATCH] " Raslan Darawsheh
2025-03-23 13:14 ` Morten Brørup
2025-03-24 7:34 ` Raslan Darawsheh
2025-03-24 7:43 ` Morten Brørup
2025-03-24 7:44 ` Morten Brørup
2025-03-24 8:32 ` Raslan Darawsheh
2025-03-24 8:45 ` Morten Brørup
2025-03-23 16:00 ` Stephen Hemminger
2025-03-24 7:37 ` Raslan Darawsheh
2025-03-23 16:39 ` Thomas Monjalon
2025-03-24 7:38 ` Raslan Darawsheh
2025-03-24 8:50 ` Raslan Darawsheh [this message]
2025-03-24 9:04 ` [PATCH v2] " Morten Brørup
2025-03-24 9:40 ` Raslan Darawsheh
2025-03-24 9:33 ` [PATCH v3] " Raslan Darawsheh
2025-03-24 13:18 ` Morten Brørup
2025-03-24 16:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324085023.23721-1-rasland@nvidia.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=haijie1@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).