[PATCH v0 1/1] net/octeon_ep: fix buffer refill failure

[PATCH v0 1/1] net/octeon_ep: fix buffer refill failure

[Vamsi Krishna]

From: Vidya Sagar Velumuri <vvelumuri@marvell.com>

Fix the buffer refill for SDP output queue
Fixes: ab09499e809c ("net/octeon_ep: add SSE Rx")

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Acked-by: Vamsi Krishna Attunuru <vattunuru@marvell.com>
---
 drivers/net/octeon_ep/cnxk_ep_rx.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/octeon_ep/cnxk_ep_rx.h b/drivers/net/octeon_ep/cnxk_ep_rx.h
index 83677e1c6f..5db32c4448 100644
--- a/drivers/net/octeon_ep/cnxk_ep_rx.h
+++ b/drivers/net/octeon_ep/cnxk_ep_rx.h
@@ -72,11 +72,10 @@ cnxk_ep_rx_refill(struct otx_ep_droq *droq)
 		desc_refilled = count;
 		count = droq->read_idx;
 		rc = cnxk_ep_rx_refill_mbuf(droq, count);
-		if (unlikely(rc)) {
+		if (unlikely(rc))
 			droq->stats.rx_alloc_failure++;
-			return;
-		}
-		desc_refilled += count;
+		else
+			desc_refilled += count;
 	}
 
 	/* Flush the droq descriptor data to memory to be sure
-- 
2.34.1

RE: [PATCH v0 1/1] net/octeon_ep: fix buffer refill failure

[Jerin Jacob]

> -----Original Message-----
> From: Vamsi Krishna <vattunuru@marvell.com>
> Sent: Monday, March 24, 2025 4:39 PM
> To: dev@dpdk.org
> Cc: Jerin Jacob <jerinj@marvell.com>; Vamsi Krishna Attunuru
> <vattunuru@marvell.com>; Vidya Sagar Velumuri <vvelumuri@marvell.com>
> Subject: [PATCH v0 1/1] net/octeon_ep: fix buffer refill failure
> 
> From: Vidya Sagar Velumuri <vvelumuri@marvell.com>
> 
> Fix the buffer refill for SDP output queue
> Fixes: ab09499e809c ("net/octeon_ep: add SSE Rx")
> 
> Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
> Acked-by: Vamsi Krishna Attunuru <vattunuru@marvell.com>



Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-main. Thanks

commit 5b1a795452a09eb6a0b0a4d8eccd113c1c53f131 (HEAD -> for-main)
Author: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Date:   Mon Mar 24 16:38:50 2025 +0530

    net/octeon_ep: fix buffer refill

    Fix the buffer refill for SDP output queue

    Fixes: ab09499e809c ("net/octeon_ep: add SSE Rx")
    Cc: stable@dpdk.org

    Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
    Acked-by: Vamsi Attunuru <vattunuru@marvell.com>


> ---
>  drivers/net/octeon_ep/cnxk_ep_rx.h | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/octeon_ep/cnxk_ep_rx.h
> b/drivers/net/octeon_ep/cnxk_ep_rx.h
> index 83677e1c6f..5db32c4448 100644
> --- a/drivers/net/octeon_ep/cnxk_ep_rx.h
> +++ b/drivers/net/octeon_ep/cnxk_ep_rx.h
> @@ -72,11 +72,10 @@ cnxk_ep_rx_refill(struct otx_ep_droq *droq)
>  		desc_refilled = count;
>  		count = droq->read_idx;
>  		rc = cnxk_ep_rx_refill_mbuf(droq, count);
> -		if (unlikely(rc)) {
> +		if (unlikely(rc))
>  			droq->stats.rx_alloc_failure++;
> -			return;
> -		}
> -		desc_refilled += count;
> +		else
> +			desc_refilled += count;
>  	}
> 
>  	/* Flush the droq descriptor data to memory to be sure
> --
> 2.34.1