From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B794D46488; Wed, 26 Mar 2025 16:53:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1303440674; Wed, 26 Mar 2025 16:52:48 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 55E9E40674; Wed, 26 Mar 2025 16:52:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743004365; x=1774540365; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cw1Y6GPz09FwWl27MJX/fHhErTKrq5CCxDjrOvUjphE=; b=e0p9ULwH+foU1GPse/KZXlxOJETIlVmkuTGe2yZoEIHOmuLpldUYPKY3 3vm/DSLp0KIUT+2/TjGPsV+Kdh9xuPnBrWwmBF3HyGQkEu2/Jlp72f1Pg IrxSlZoHVJXBo3nuzTafM8gMn2a2w0YHPbpyqE8tOrmnWM+mTXbl5q15I LxbAiDobIt2dGeYF/7PaKKoex3/Oy/LR/em9A30aVpdGhYT32i5KN5e4K UxD0QOEym2h0VM8wpxWr9Ois7ziNpRSiY8HrJtpkfzcZnwoYL/7Vuay43 WlipDjxhzm35jxtCXklJEBLY00802xSiJCMNj+bQsgkVMvyMF9Hi5qgtF Q==; X-CSE-ConnectionGUID: 3j5W+tCWSl6kA0eHvSukoA== X-CSE-MsgGUID: Rr3R+HZKQO2ahgAKQ25EKw== X-IronPort-AV: E=McAfee;i="6700,10204,11385"; a="44188325" X-IronPort-AV: E=Sophos;i="6.14,278,1736841600"; d="scan'208";a="44188325" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2025 08:52:45 -0700 X-CSE-ConnectionGUID: +MlcQgg2Tz+Gp8kUCE4QbA== X-CSE-MsgGUID: WxrYhlmrRxa28liocSek9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,278,1736841600"; d="scan'208";a="124550913" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.31]) by orviesa009.jf.intel.com with ESMTP; 26 Mar 2025 08:52:43 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org, Ian Stokes , Helin Zhang , Jijiang Liu , Jingjing Wu , Jing Chen , Heqing Zhu Subject: [PATCH 4/7] net/i40e/base: fix unused value warnings Date: Wed, 26 Mar 2025 15:52:26 +0000 Message-ID: <20250326155230.1315056-5-bruce.richardson@intel.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250326155230.1315056-1-bruce.richardson@intel.com> References: <20250326155230.1315056-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix warnings about unused values - parameters, variables, etc., and remove the warning disable flags for them. Although modifying the base-code files is not ideal, the changes required are minor, and only affect two files from the imported base code. Fixes: 8db9e2a1b232 ("i40e: base driver") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- drivers/net/intel/i40e/base/i40e_nvm.c | 2 +- drivers/net/intel/i40e/base/i40e_osdep.h | 4 ++-- drivers/net/intel/i40e/base/i40e_type.h | 14 +++++++++----- drivers/net/intel/i40e/base/meson.build | 3 --- drivers/net/intel/i40e/i40e_ethdev.c | 1 + 5 files changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/net/intel/i40e/base/i40e_nvm.c b/drivers/net/intel/i40e/base/i40e_nvm.c index 3e16a0d997..56dc4d9279 100644 --- a/drivers/net/intel/i40e/base/i40e_nvm.c +++ b/drivers/net/intel/i40e/base/i40e_nvm.c @@ -1743,7 +1743,7 @@ STATIC enum i40e_status_code i40e_nvmupd_get_aq_result(struct i40e_hw *hw, **/ STATIC enum i40e_status_code i40e_nvmupd_get_aq_event(struct i40e_hw *hw, struct i40e_nvm_access *cmd, - u8 *bytes, int *perrno) + u8 *bytes, __rte_unused int *perrno) { u32 aq_total_len; u32 aq_desc_len; diff --git a/drivers/net/intel/i40e/base/i40e_osdep.h b/drivers/net/intel/i40e/base/i40e_osdep.h index c04f94732a..197f4678bf 100644 --- a/drivers/net/intel/i40e/base/i40e_osdep.h +++ b/drivers/net/intel/i40e/base/i40e_osdep.h @@ -184,8 +184,8 @@ struct __rte_packed_begin i40e_dma_mem { const void *zone; } __rte_packed_end; -#define i40e_allocate_dma_mem(h, m, unused, s, a) \ - i40e_allocate_dma_mem_d(h, m, s, a) +#define i40e_allocate_dma_mem(h, m, mt, s, a) \ + i40e_allocate_dma_mem_d(h, m, mt, s, a) #define i40e_free_dma_mem(h, m) i40e_free_dma_mem_d(h, m) struct __rte_packed_begin i40e_virt_mem { diff --git a/drivers/net/intel/i40e/base/i40e_type.h b/drivers/net/intel/i40e/base/i40e_type.h index 7cc746f82f..968e1982a6 100644 --- a/drivers/net/intel/i40e/base/i40e_type.h +++ b/drivers/net/intel/i40e/base/i40e_type.h @@ -14,11 +14,15 @@ #include "i40e_devids.h" #define UNREFERENCED_XPARAMETER -#define UNREFERENCED_1PARAMETER(_p) (_p); -#define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q); -#define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r); -#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s); -#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); (_t); +#define UNREFERENCED_1PARAMETER(_p) (void)(_p) +#define UNREFERENCED_2PARAMETER(_p, _q) \ + do { (void)(_p); (void)(_q); } while (0) +#define UNREFERENCED_3PARAMETER(_p, _q, _r) \ + do { (void)(_p); (void)(_q); (void)(_r); } while (0) +#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) \ + do { (void)(_p); (void)(_q); (void)(_r); (void)(_s); } while (0) +#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) \ + do { (void)(_p); (void)(_q); (void)(_r); (void)(_s); (void)(_t); } while (0) #define BIT(a) (1UL << (a)) #define BIT_ULL(a) (1ULL << (a)) diff --git a/drivers/net/intel/i40e/base/meson.build b/drivers/net/intel/i40e/base/meson.build index a0912b1788..2648e5d0c4 100644 --- a/drivers/net/intel/i40e/base/meson.build +++ b/drivers/net/intel/i40e/base/meson.build @@ -13,10 +13,7 @@ sources = [ error_cflags = [ '-Wno-sign-compare', - '-Wno-unused-value', '-Wno-strict-aliasing', - '-Wno-unused-but-set-variable', - '-Wno-unused-parameter', ] c_args = cflags foreach flag: error_cflags diff --git a/drivers/net/intel/i40e/i40e_ethdev.c b/drivers/net/intel/i40e/i40e_ethdev.c index 1c5ab35a8b..90eba3419f 100644 --- a/drivers/net/intel/i40e/i40e_ethdev.c +++ b/drivers/net/intel/i40e/i40e_ethdev.c @@ -4694,6 +4694,7 @@ i40e_dev_rss_reta_query(struct rte_eth_dev *dev, enum i40e_status_code i40e_allocate_dma_mem_d(__rte_unused struct i40e_hw *hw, struct i40e_dma_mem *mem, + __rte_unused enum i40e_memory_type mtype, u64 size, u32 alignment) { -- 2.45.2