From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
To: Wathsala Vithanage <wathsala.vithanage@arm.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <gakhil@marvell.com>,
Rahul Bhansali <rbhansali@marvell.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>, <ndabilpuram@marvell.com>,
"Rakesh Kudurumalla" <rkudurumalla@marvell.com>
Subject: [PATCH 1/1] examples/ipsec-secgw: resolve segfault for IPv6 packets
Date: Thu, 27 Mar 2025 12:33:00 +0530 [thread overview]
Message-ID: <20250327070300.2839933-1-rkudurumalla@marvell.com> (raw)
While running ipsec-secgw application if IPV6 rules are not
configured in ipsec configuration lpm look up fails and
destination port is updated as BAD_PORT.During process_packet
ethernet_hdr is updated resulting in crash due out of bound.
This patch fixes the same.
Fixes: 6eb3ba03995c ("examples/ipsec-secgw: support poll mode NEON LPM lookup")
Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
examples/ipsec-secgw/ipsec_neon.h | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/examples/ipsec-secgw/ipsec_neon.h b/examples/ipsec-secgw/ipsec_neon.h
index 8b93b4b52e..fc04000336 100644
--- a/examples/ipsec-secgw/ipsec_neon.h
+++ b/examples/ipsec-secgw/ipsec_neon.h
@@ -23,6 +23,7 @@ processx4_step3(struct rte_mbuf *pkts[FWDSTEP], uint16_t dst_port[FWDSTEP],
uint32x4_t ve[FWDSTEP];
uint32_t *p[FWDSTEP];
struct rte_mbuf *pkt;
+ uint16_t port;
uint32_t val;
uint8_t i;
@@ -34,7 +35,8 @@ processx4_step3(struct rte_mbuf *pkts[FWDSTEP], uint16_t dst_port[FWDSTEP],
*l_pkt |= 1;
p[i] = rte_pktmbuf_mtod(pkt, uint32_t *);
- ve[i] = vreinterpretq_u32_s32(val_eth[dst_port[i]]);
+ port = (dst_port[i] == BAD_PORT) ? 0 : dst_port[i];
+ ve[i] = vreinterpretq_u32_s32(val_eth[port]);
te[i] = vld1q_u32(p[i]);
/* Update last 4 bytes */
@@ -76,6 +78,7 @@ process_packet(struct rte_mbuf *pkt, uint16_t *dst_port, uint64_t tx_offloads,
{
struct rte_ether_hdr *eth_hdr;
uint32x4_t te, ve;
+ uint16_t port;
uint32_t val;
/* Check if it is a large packet */
@@ -85,7 +88,8 @@ process_packet(struct rte_mbuf *pkt, uint16_t *dst_port, uint64_t tx_offloads,
eth_hdr = rte_pktmbuf_mtod(pkt, struct rte_ether_hdr *);
te = vld1q_u32((uint32_t *)eth_hdr);
- ve = vreinterpretq_u32_s32(val_eth[dst_port[0]]);
+ port = (dst_port[0] == BAD_PORT) ? 0 : dst_port[0];
+ ve = vreinterpretq_u32_s32(val_eth[port]);
val = vgetq_lane_u32(te, 3);
#if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
--
2.25.1
reply other threads:[~2025-03-27 7:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250327070300.2839933-1-rkudurumalla@marvell.com \
--to=rkudurumalla@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=rbhansali@marvell.com \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).