From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E365946491;
Thu, 27 Mar 2025 10:01:21 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id D2DCA4066F;
Thu, 27 Mar 2025 10:01:21 +0100 (CET)
Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])
by mails.dpdk.org (Postfix) with ESMTP id 578F14066C
for <dev@dpdk.org>; Thu, 27 Mar 2025 10:01:20 +0100 (CET)
Received: from mail.maildlp.com (unknown [172.19.163.17])
by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4ZNd2D4jPsz27hQZ;
Thu, 27 Mar 2025 17:01:56 +0800 (CST)
Received: from kwepemo500011.china.huawei.com (unknown [7.202.195.194])
by mail.maildlp.com (Postfix) with ESMTPS id B78851A0188;
Thu, 27 Mar 2025 17:01:18 +0800 (CST)
Received: from localhost.huawei.com (10.50.165.33) by
kwepemo500011.china.huawei.com (7.202.195.194) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.1544.11; Thu, 27 Mar 2025 17:01:18 +0800
From: Dengdui Huang <huangdengdui@huawei.com>
To: <dev@dpdk.org>
CC: <honest.jiang@foxmail.com>, <fengchengwen@huawei.com>,
<roretzla@linux.microsoft.com>, <lihuisong@huawei.com>, <haijie1@huawei.com>,
<liuyonglong@huawei.com>, <stephen@networkplumber.org>
Subject: [PATCH v2 1/2] eal: fix uncheck worker ID
Date: Thu, 27 Mar 2025 17:01:15 +0800
Message-ID: <20250327090116.3357137-2-huangdengdui@huawei.com>
X-Mailer: git-send-email 2.33.0
In-Reply-To: <20250327090116.3357137-1-huangdengdui@huawei.com>
References: <20250321040316.104126-1-huangdengdui@huawei.com>
<20250327090116.3357137-1-huangdengdui@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.50.165.33]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
kwepemo500011.china.huawei.com (7.202.195.194)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
The worker_id may come from user input.
So it is necessary to verify it.
Fixes: a95d70547c57 ("eal: factorize lcore main loop")
Cc: stable@dpdk.org
Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
---
lib/eal/common/eal_common_launch.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/eal/common/eal_common_launch.c b/lib/eal/common/eal_common_launch.c
index 5320c3bd3c..76313d5cdf 100644
--- a/lib/eal/common/eal_common_launch.c
+++ b/lib/eal/common/eal_common_launch.c
@@ -35,6 +35,9 @@ rte_eal_remote_launch(lcore_function_t *f, void *arg, unsigned int worker_id)
{
int rc = -EBUSY;
+ if (!rte_lcore_has_role(worker_id, ROLE_RTE))
+ return -EINVAL;
+
/* Check if the worker is in 'WAIT' state. Use acquire order
* since 'state' variable is used as the guard variable.
*/
--
2.33.0