From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23664464CF; Wed, 2 Apr 2025 14:25:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1547340273; Wed, 2 Apr 2025 14:25:05 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id D9A2F40261 for ; Wed, 2 Apr 2025 14:25:01 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4ZSP9Q4X9lzWfnK; Wed, 2 Apr 2025 20:21:14 +0800 (CST) Received: from kwepemo500011.china.huawei.com (unknown [7.202.195.194]) by mail.maildlp.com (Postfix) with ESMTPS id B2968180103; Wed, 2 Apr 2025 20:24:56 +0800 (CST) Received: from localhost.huawei.com (10.50.165.33) by kwepemo500011.china.huawei.com (7.202.195.194) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 2 Apr 2025 20:24:56 +0800 From: Dengdui Huang To: CC: , , , , , , , , Subject: [PATCH v3 2/3] eal: fix unckeck pipe Date: Wed, 2 Apr 2025 20:24:53 +0800 Message-ID: <20250402122454.2148612-3-huangdengdui@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20250402122454.2148612-1-huangdengdui@huawei.com> References: <20250321040316.104126-1-huangdengdui@huawei.com> <20250402122454.2148612-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemo500011.china.huawei.com (7.202.195.194) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The communication pipe may be unavailable, for example, when the lcore role is ROLE_OFF or ROLE_NON_EAL. So check whether the pipe is available before using it. Fixes: a95d70547c57 ("eal: factorize lcore main loop") Cc: stable@dpdk.org Signed-off-by: Dengdui Huang --- lib/eal/unix/eal_unix_thread.c | 3 +++ lib/eal/windows/eal_thread.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/lib/eal/unix/eal_unix_thread.c b/lib/eal/unix/eal_unix_thread.c index ef6cbff0ee..103571cabf 100644 --- a/lib/eal/unix/eal_unix_thread.c +++ b/lib/eal/unix/eal_unix_thread.c @@ -17,6 +17,9 @@ eal_thread_wake_worker(unsigned int worker_id) char c = 0; int n; + if (m2w == 0 || w2m == 0) + return -EINVAL; + do { n = write(m2w, &c, 1); } while (n == 0 || (n < 0 && errno == EINTR)); diff --git a/lib/eal/windows/eal_thread.c b/lib/eal/windows/eal_thread.c index 9e3df200b9..82bb974868 100644 --- a/lib/eal/windows/eal_thread.c +++ b/lib/eal/windows/eal_thread.c @@ -24,6 +24,9 @@ eal_thread_wake_worker(unsigned int worker_id) char c = 0; int n; + if (m2w == 0 || w2m == 0) + return -EINVAL; + do { n = _write(m2w, &c, 1); } while (n == 0 || (n < 0 && errno == EINTR)); -- 2.33.0