From: Stephen Hemminger <stephen@networkplumber.org>
To: liwencheng <liwencheng@phytium.com.cn>
Cc: dev@dpdk.org
Subject: Re: [PATCH v4 2/4] net/macb: add new poll mode driver
Date: Wed, 2 Apr 2025 18:45:31 -0700 [thread overview]
Message-ID: <20250402184531.2b90d0bf@hermes.local> (raw)
In-Reply-To: <1743577136-119797-1-git-send-email-liwencheng@phytium.com.cn>
On Wed, 2 Apr 2025 06:58:56 +0000
liwencheng <liwencheng@phytium.com.cn> wrote:
> add Phytium NIC MACB ethdev PMD driver.
>
> v4:
> * Changed functions that always return 0 and whose return value
> is unused to void type, improving code simplicity and readability.
> * Fixed the implicit conversion issues in the
> macb_usxgmii_pcs_check_for_link and
> macb_usxgmii_pcs_check_for_link functions.
> * Added the missing SPDX license tags.
> * Fix tab errors in meson.build file.
> * Use RTE_LOG_LINE instead of rte_log.
> * Replace %l with %PRI*64.
> * Replace rte_smp_[r/w]mb with rte_[r/w]mb.
> * Do not use variadic arguments in macros.
> * Do not use variable-length array pkts[nb_bufs].
> * Use __rte_cache_aligned only for struct or union types alignment.
> * Support hardware Rx/Tx checksum offload.
> * Fixed some code style issues.
>
> Signed-off-by: liwencheng <liwencheng@phytium.com.cn>
> ---
> drivers/net/macb/base/generic_phy.c | 271 +++++
> drivers/net/macb/base/generic_phy.h | 202 ++++
> drivers/net/macb/base/macb_common.c | 670 +++++++++++++
> drivers/net/macb/base/macb_common.h | 254 +++++
> drivers/net/macb/base/macb_errno.h | 58 ++
> drivers/net/macb/base/macb_hw.h | 1138 +++++++++++++++++++++
> drivers/net/macb/base/macb_type.h | 23 +
> drivers/net/macb/base/macb_uio.c | 351 +++++++
> drivers/net/macb/base/macb_uio.h | 50 +
> drivers/net/macb/base/meson.build | 26 +
> drivers/net/macb/base/motorcomm.c | 645 ++++++++++++
> drivers/net/macb/base/motorcomm.h | 85 ++
> drivers/net/macb/macb_ethdev.c | 1866 +++++++++++++++++++++++++++++++++++
> drivers/net/macb/macb_ethdev.h | 96 ++
> drivers/net/macb/macb_log.h | 19 +
> drivers/net/macb/macb_rxtx.c | 1391 ++++++++++++++++++++++++++
> drivers/net/macb/macb_rxtx.h | 325 ++++++
> drivers/net/macb/meson.build | 18 +
> drivers/net/meson.build | 1 +
> 19 files changed, 7489 insertions(+)
> create mode 100644 drivers/net/macb/base/generic_phy.c
> create mode 100644 drivers/net/macb/base/generic_phy.h
> create mode 100644 drivers/net/macb/base/macb_common.c
> create mode 100644 drivers/net/macb/base/macb_common.h
> create mode 100644 drivers/net/macb/base/macb_errno.h
> create mode 100644 drivers/net/macb/base/macb_hw.h
> create mode 100644 drivers/net/macb/base/macb_type.h
> create mode 100644 drivers/net/macb/base/macb_uio.c
> create mode 100644 drivers/net/macb/base/macb_uio.h
> create mode 100644 drivers/net/macb/base/meson.build
> create mode 100644 drivers/net/macb/base/motorcomm.c
> create mode 100644 drivers/net/macb/base/motorcomm.h
File missing requires SPDX tag.
$ ./devtools/check-spdx-tag.sh
drivers/net/macb/base/motorcomm.h
total: 1 missing SPDX, 0 license errors, 0 warnings
next prev parent reply other threads:[~2025-04-03 1:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 6:58 liwencheng
2025-04-03 1:43 ` Stephen Hemminger
2025-04-03 1:45 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-12-10 7:04 [PATCH v3 1/6] net/macb: add new driver Wencheng Li
2025-04-02 7:09 ` [PATCH v4 2/4] net/macb: add new poll mode driver liwencheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402184531.2b90d0bf@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liwencheng@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).