From: Stephen Hemminger <stephen@networkplumber.org>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, <dev@dpdk.org>
Subject: Re: [RFC PATCH 1/4] ethdev: add support to provide link type
Date: Thu, 3 Apr 2025 17:46:47 -0700 [thread overview]
Message-ID: <20250403174647.1d9e5742@hermes.local> (raw)
In-Reply-To: <20250403070837.926292-1-ndabilpuram@marvell.com>
On Thu, 3 Apr 2025 12:38:34 +0530
Nithin Dabilpuram <ndabilpuram@marvell.com> wrote:
> /**
> * A structure used to retrieve link-level information of an Ethernet port.
> */
> @@ -341,6 +354,7 @@ struct rte_eth_link {
> uint16_t link_duplex : 1; /**< RTE_ETH_LINK_[HALF/FULL]_DUPLEX */
> uint16_t link_autoneg : 1; /**< RTE_ETH_LINK_[AUTONEG/FIXED] */
> uint16_t link_status : 1; /**< RTE_ETH_LINK_[DOWN/UP] */
> + uint16_t link_type : 5; /**< RTE_ETH_LINK_TYPE_* */
> };
> };
> };
Seems like an ABI break, and not sure that all drivers will fill those bits with zero now.
prev parent reply other threads:[~2025-04-04 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 7:08 Nithin Dabilpuram
2025-04-03 7:08 ` [RFC PATCH 2/4] common/cnxk: support to get speed cap from fwdata Nithin Dabilpuram
2025-04-03 7:08 ` [RFC PATCH 3/4] common/cnxk: provide port type " Nithin Dabilpuram
2025-04-03 7:08 ` [RFC PATCH 4/4] net/cnxk: report link type along with link status Nithin Dabilpuram
2025-04-04 0:46 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403174647.1d9e5742@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=ndabilpuram@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).