From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com,
Bruce Richardson <bruce.richardson@intel.com>,
Jie Hai <haijie1@huawei.com>
Subject: [RFC PATCH] drivers: add generic build of SVE files
Date: Mon, 7 Apr 2025 16:28:57 +0100 [thread overview]
Message-ID: <20250407152857.2203839-1-bruce.richardson@intel.com> (raw)
For SVE, as for AVX2 and AVX-512, support building files for these ISAs
from the top-level drivers/meson.build file, rather than having each
driver re-implement it.
This removes the remaining build task for drivers in DPDK which is
being done by a driver itself, rather than in the generic drivers'
build rules.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/meson.build | 27 +++++++++++++++++++++++++++
drivers/net/hns3/meson.build | 22 +---------------------
2 files changed, 28 insertions(+), 21 deletions(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index b2d2537dc8..a6f0670a2f 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -128,6 +128,7 @@ foreach subpath:subdirs
sources = []
sources_avx2 = []
sources_avx512 = []
+ sources_sve = []
headers = []
driver_sdk_headers = [] # public headers included by drivers
objs = []
@@ -285,6 +286,32 @@ foreach subpath:subdirs
endif
endif
+ if (arch_subdir == 'arm' and sources_sve.length() > 0
+ and cc.has_argument('-march=armv8.2-a+sve')
+ and cc.check_header('arm_sve.h'))
+
+ if dpdk_conf.has('RTE_HAS_SVE_ACLE')
+ sources += sources_sve
+ else
+ cflags += ['-DRTE_HAS_SVE_ACLE=1']
+ sve_cflags = ['-march=armv8.2-a+sve']
+ foreach flag: cflags
+ if (flag.startswith('-march=')
+ or flag.startswith('-mcpu=')
+ or flag.startswith('-mtune='))
+ continue
+ endif
+ sve_cflags += flag
+ endforeach
+ sve_lib = static_library(libname + '_sve_lib',
+ sources_sve,
+ dependencies: static_deps,
+ include_directories: includes,
+ c_args: sve_cflags)
+ objs += sve_lib.extract_objects(sources_sve)
+ endif
+ endif
+
# generate pmdinfo sources by building a temporary
# lib and then running pmdinfogen on the contents of
# that lib. The final lib reuses the object files and
diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build
index 53a9dd6f39..87f04aa440 100644
--- a/drivers/net/hns3/meson.build
+++ b/drivers/net/hns3/meson.build
@@ -43,25 +43,5 @@ cflags += no_wvla_cflag
if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
sources += files('hns3_rxtx_vec.c')
-
- # compile SVE when:
- # a. support SVE in minimum instruction set baseline
- # b. it's not minimum instruction set, but compiler support
- if dpdk_conf.has('RTE_HAS_SVE_ACLE')
- sources += files('hns3_rxtx_vec_sve.c')
- elif cc.has_argument('-march=armv8.2-a+sve') and cc.check_header('arm_sve.h')
- cflags += ['-DRTE_HAS_SVE_ACLE=1']
- sve_cflags = []
- foreach flag: cflags
- if not (flag.startswith('-march=') or flag.startswith('-mcpu=') or flag.startswith('-mtune='))
- sve_cflags += flag
- endif
- endforeach
- hns3_sve_lib = static_library('hns3_sve_lib',
- 'hns3_rxtx_vec_sve.c',
- dependencies: [static_rte_ethdev],
- include_directories: includes,
- c_args: [sve_cflags, '-march=armv8.2-a+sve'])
- objs += hns3_sve_lib.extract_objects('hns3_rxtx_vec_sve.c')
- endif
+ sources_sve += files('hns3_rxtx_vec_sve.c')
endif
--
2.45.2
next reply other threads:[~2025-04-07 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 15:28 Bruce Richardson [this message]
2025-04-07 15:35 ` Bruce Richardson
2025-04-07 15:49 ` David Marchand
2025-04-07 16:10 ` Bruce Richardson
2025-04-08 17:10 ` Wathsala Wathawana Vithanage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407152857.2203839-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=haijie1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).