* [PATCH] common/mlx5: fix build on Linux in dlopen link mode
@ 2025-04-08 7:47 Thomas Monjalon
2025-04-08 7:57 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2025-04-08 7:47 UTC (permalink / raw)
To: dev
Cc: Ali Alnubani, Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao,
Ori Kam, Suanming Mou, Matan Azrad, David Marchand
When using the Meson option "ibverbs_link=dlopen",
a glue library is built.
After the recent change requiring eal_export.h,
the build stopped because the internal EAL include directory
was unknown to this glue library:
drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal error:
eal_export.h: No such file or directory
Fixes: c7020bb20fc7 ("build: mark exported symbols")
Reported-by: Ali Alnubani <alialnu@nvidia.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/common/mlx5/linux/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/mlx5/linux/meson.build b/drivers/common/mlx5/linux/meson.build
index 58d0328c6d..5548a56199 100644
--- a/drivers/common/mlx5/linux/meson.build
+++ b/drivers/common/mlx5/linux/meson.build
@@ -237,7 +237,7 @@ if dlopen_ibverbs
dlopen_sources = files('mlx5_glue.c')
dlopen_install_dir = [ eal_pmd_path + '-glue' ]
dlopen_includes = [global_inc]
- dlopen_includes += include_directories('../../../../lib/eal/include/generic')
+ dlopen_includes += include_directories('../../../../lib/eal/common')
dlopen_includes += include_directories('..')
shared_lib = shared_library(
dlopen_lib_name,
--
2.47.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] common/mlx5: fix build on Linux in dlopen link mode
2025-04-08 7:47 [PATCH] common/mlx5: fix build on Linux in dlopen link mode Thomas Monjalon
@ 2025-04-08 7:57 ` David Marchand
2025-04-08 8:18 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2025-04-08 7:57 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, Ali Alnubani, Dariusz Sosnowski, Viacheslav Ovsiienko,
Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad
On Tue, Apr 8, 2025 at 9:47 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> When using the Meson option "ibverbs_link=dlopen",
> a glue library is built.
>
> After the recent change requiring eal_export.h,
> the build stopped because the internal EAL include directory
> was unknown to this glue library:
>
> drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal error:
> eal_export.h: No such file or directory
>
> Fixes: c7020bb20fc7 ("build: mark exported symbols")
>
> Reported-by: Ali Alnubani <alialnu@nvidia.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
lgtm.
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] common/mlx5: fix build on Linux in dlopen link mode
2025-04-08 7:57 ` David Marchand
@ 2025-04-08 8:18 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2025-04-08 8:18 UTC (permalink / raw)
To: Ali Alnubani, David Marchand
Cc: dev, Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao, Ori Kam,
Suanming Mou, Matan Azrad
08/04/2025 09:57, David Marchand:
> On Tue, Apr 8, 2025 at 9:47 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > When using the Meson option "ibverbs_link=dlopen",
> > a glue library is built.
> >
> > After the recent change requiring eal_export.h,
> > the build stopped because the internal EAL include directory
> > was unknown to this glue library:
> >
> > drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal error:
> > eal_export.h: No such file or directory
> >
> > Fixes: c7020bb20fc7 ("build: mark exported symbols")
> >
> > Reported-by: Ali Alnubani <alialnu@nvidia.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> lgtm.
> Acked-by: David Marchand <david.marchand@redhat.com>
Applied quickly to fix the build.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-08 8:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-08 7:47 [PATCH] common/mlx5: fix build on Linux in dlopen link mode Thomas Monjalon
2025-04-08 7:57 ` David Marchand
2025-04-08 8:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).