From: Dengdui Huang <huangdengdui@huawei.com>
To: <dev@dpdk.org>
Cc: <stephen@networkplumber.org>, <lihuisong@huawei.com>,
<fengchengwen@huawei.com>, <haijie1@huawei.com>,
<liuyonglong@huawei.com>
Subject: [PATCH 5/7] net/hns3: fix incorrect failed rollback
Date: Tue, 8 Apr 2025 16:30:58 +0800 [thread overview]
Message-ID: <20250408083100.2845040-6-huangdengdui@huawei.com> (raw)
In-Reply-To: <20250408083100.2845040-1-huangdengdui@huawei.com>
When the port is started, if the Tx queue fails to be started,
the map interrupt should be rolled back.
Fixes: fdfde7a4a0f8 ("net/hns3: fix mbuf leakage")
Cc: stable@dpdk.org
Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
---
drivers/net/hns3/hns3_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 20ad249b8b..2b56b6e44e 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -5122,7 +5122,7 @@ hns3_dev_start(struct rte_eth_dev *dev)
*/
ret = hns3_start_all_txqs(dev);
if (ret)
- goto map_rx_inter_err;
+ goto start_all_txqs_fail;
ret = hns3_start_all_rxqs(dev);
if (ret)
@@ -5155,6 +5155,8 @@ hns3_dev_start(struct rte_eth_dev *dev)
start_all_rxqs_fail:
hns3_stop_all_txqs(dev);
+start_all_txqs_fail:
+ hns3_unmap_rx_interrupt(dev);
map_rx_inter_err:
(void)hns3_do_stop(hns);
do_start_fail:
--
2.33.0
next prev parent reply other threads:[~2025-04-08 8:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 8:30 [PATCH 0/7] net/hns3: bugfix for hns3 Dengdui Huang
2025-04-08 8:30 ` [PATCH 1/7] net/hns3: fix variable overflow Dengdui Huang
2025-04-08 8:30 ` [PATCH 2/7] net/hns3: fix memory leakage in failure path Dengdui Huang
2025-04-08 8:30 ` [PATCH 3/7] net/hns3: fix extra waiting for link up Dengdui Huang
2025-04-08 8:30 ` [PATCH 4/7] net/hns3: fix memory leakage for indirect action Dengdui Huang
2025-04-08 8:30 ` Dengdui Huang [this message]
2025-04-08 8:30 ` [PATCH 6/7] net/hns3: fix divide by zero Dengdui Huang
2025-04-08 8:31 ` [PATCH 7/7] net/hns3: fix unrelease some resources on reset case Dengdui Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408083100.2845040-6-huangdengdui@huawei.com \
--to=huangdengdui@huawei.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=haijie1@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).