From: Patrick Robb <probb@iol.unh.edu>
To: Paul.Szczepanek@arm.com
Cc: probb@iol.unh.edu, Luca.Vizzarro@arm.com, dev@dpdk.org,
dmarx@iol.unh.edu, npratte@iol.unh.edu
Subject: [PATCH 0/4] dts: smoke test bugfixes
Date: Wed, 9 Apr 2025 18:38:21 -0400 [thread overview]
Message-ID: <20250409223825.1579256-1-probb@iol.unh.edu> (raw)
In-Reply-To: <20250403023059.1762841-1-probb@iol.unh.edu>
There are two smoke test bugfixes which have come in from our 25.03 DTS
development and which should be resolved with this series.
1. The patchseries which we merged for 25.03 which added the testsuite
specific configs inadvertently broke enabling smoke tests, as we build
the tests config model using the test suite list coming in from the
parsed test_run.yaml, before smoke_tests have been added. Then, later in
the execution this produces a key error. I think that adding a
placeholder smoke tests test suite config is the most reasonable
solution to this. Users are unlikely to specify any test config for
smoke tests as they don't require any, although if they happen to do so,
I understand this change to be non-breaking (and I gave it a test run).
2. I am also seeing the smoke test which relies on regex on
dpdk-devbind.py status output is failing on at least one of our systems
currently. The fact that this broke is rather peculiar since regex
syntax is obviously stable, and my reading of the current regex is that
it "should" work. In any case, I simply changed the regex to a pattern
which is more permissive and still captures the driver in use, which is
what is needed for the testsuite.
changes in v2:
The v2 patchseries adds an extension to the smoke test meson fast tests
timeout in order to accommodate for slower test times on older systems.
The v2 also disables smoke tests in the example testrun config file,
based on discussion at the previous DTS meeting. In some cases
there are esoteric reasons why some meson tests may fail, and they will
also extend the test run execution time. For these reasons we think that
smoke tests should be opt in by default instead of opt out by default.
Patrick Robb (4):
dts: include smoke tests in tests config
dts: update dpdk-devbind script regex
dts: default smoke tests to off
dts: extend meson fast tests timeout
dts/framework/config/test_run.py | 7 +++++--
dts/test_run.example.yaml | 2 +-
dts/tests/TestSuite_smoke_tests.py | 4 ++--
3 files changed, 8 insertions(+), 5 deletions(-)
--
2.48.1
next prev parent reply other threads:[~2025-04-09 22:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 2:30 [PATCH 0/2] " Patrick Robb
2025-04-03 2:30 ` [PATCH 1/2] dts: include smoke tests in tests config Patrick Robb
2025-04-03 13:45 ` Luca Vizzarro
2025-04-03 13:42 ` Patrick Robb
2025-04-03 2:30 ` [PATCH 2/2] dts: update dpdk-devbind script regex Patrick Robb
2025-04-03 13:45 ` Luca Vizzarro
2025-04-09 22:38 ` Patrick Robb [this message]
2025-04-09 22:38 ` [PATCH 1/4] dts: include smoke tests in tests config Patrick Robb
2025-04-09 22:38 ` [PATCH 2/4] dts: update dpdk-devbind script regex Patrick Robb
2025-04-09 22:38 ` [PATCH 3/4] dts: default smoke tests to off Patrick Robb
2025-04-09 22:38 ` [PATCH 4/4] dts: extend meson fast tests timeout Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409223825.1579256-1-probb@iol.unh.edu \
--to=probb@iol.unh.edu \
--cc=Luca.Vizzarro@arm.com \
--cc=Paul.Szczepanek@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=npratte@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).