From: Patrick Robb <probb@iol.unh.edu>
To: Paul.Szczepanek@arm.com
Cc: probb@iol.unh.edu, Luca.Vizzarro@arm.com, dev@dpdk.org,
dmarx@iol.unh.edu, npratte@iol.unh.edu,
Luca Vizzarro <luca.vizzarro@arm.com>
Subject: [PATCH 1/4] dts: include smoke tests in tests config
Date: Wed, 9 Apr 2025 18:38:22 -0400 [thread overview]
Message-ID: <20250409223825.1579256-2-probb@iol.unh.edu> (raw)
In-Reply-To: <20250409223825.1579256-1-probb@iol.unh.edu>
The tests config is created by parsing the testrun config
earlier in the DTS execution than when the smoke_tests
testsuite is added. This situation causes a key error
on the tests_config dictionary when smoke_tests is enabled.
This commit creates a placeholder TestSuiteConfig for
smoke tests in the function which is responsible for
creating the tests config model, resolving the issue.
Fixes: 184d21f08db4 ("dts: add per-test-suite configuration")
Signed-off-by: Patrick Robb <probb@iol.unh.edu>
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
---
dts/framework/config/test_run.py | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/dts/framework/config/test_run.py b/dts/framework/config/test_run.py
index 06fe28143c..b6e4099eeb 100644
--- a/dts/framework/config/test_run.py
+++ b/dts/framework/config/test_run.py
@@ -301,11 +301,14 @@ def make_test_suite_config_field(config_obj: type["BaseConfig"]):
return config_obj, Field(default_factory=config_obj)
-def create_test_suites_config_model(test_suites: Iterable[TestSuiteConfig]) -> type[BaseModel]:
+def create_test_suites_config_model(test_suites: list[TestSuiteConfig]) -> type[BaseModel]:
"""Create model for the test suites configuration."""
+ complete_test_suites = [TestSuiteConfig(test_suite="smoke_tests")]
+ complete_test_suites += test_suites
+
test_suites_kwargs = {
t.test_suite_name: make_test_suite_config_field(t.test_suite_spec.config_obj)
- for t in test_suites
+ for t in complete_test_suites
}
return create_model("TestSuitesConfiguration", **test_suites_kwargs)
--
2.48.1
next prev parent reply other threads:[~2025-04-09 22:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 2:30 [PATCH 0/2] dts: smoke test bugfixes Patrick Robb
2025-04-03 2:30 ` [PATCH 1/2] dts: include smoke tests in tests config Patrick Robb
2025-04-03 13:45 ` Luca Vizzarro
2025-04-03 13:42 ` Patrick Robb
2025-04-03 2:30 ` [PATCH 2/2] dts: update dpdk-devbind script regex Patrick Robb
2025-04-03 13:45 ` Luca Vizzarro
2025-04-09 22:38 ` [PATCH 0/4] dts: smoke test bugfixes Patrick Robb
2025-04-09 22:38 ` Patrick Robb [this message]
2025-04-09 22:38 ` [PATCH 2/4] dts: update dpdk-devbind script regex Patrick Robb
2025-04-09 22:38 ` [PATCH 3/4] dts: default smoke tests to off Patrick Robb
2025-04-09 22:38 ` [PATCH 4/4] dts: extend meson fast tests timeout Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409223825.1579256-2-probb@iol.unh.edu \
--to=probb@iol.unh.edu \
--cc=Luca.Vizzarro@arm.com \
--cc=Paul.Szczepanek@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=npratte@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).