From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E32F146567; Sat, 12 Apr 2025 02:46:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C47154064C; Sat, 12 Apr 2025 02:46:17 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id DB5D540285 for ; Sat, 12 Apr 2025 02:46:16 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1213) id C368221165AD; Fri, 11 Apr 2025 17:46:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C368221165AD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1744418775; bh=AnUSbRFLzFFJ+kQ6GPSGlXvmhHDANVkaRZrcMSYg2n0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rLb+Y7Vb7e7nwl4RgWt6WL+Pr0X/QqqNNHbHKUzpBSaFzeKN0gzhfSYnuwY1Q7q7Z jaatdnJBzudm2LYv9YN2+JuFUi0//6wUEdGYUpytZYg2thMu1Tdwxm5jZy1coaLT8S dyU3jI1ywXsTkONZ0/gfMwRF1OtL5uf3n9eqDd4Y= Date: Fri, 11 Apr 2025 17:46:15 -0700 From: Andre Muezerie To: David Marchand , y@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net Cc: dev@dpdk.org, Bruce Richardson Subject: Re: [PATCH v4 1/1] mbuf: enable to be compiled with MSVC Message-ID: <20250412004615.GA23544@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1739224265-4158-1-git-send-email-andremue@linux.microsoft.com> <1744147477-23715-1-git-send-email-andremue@linux.microsoft.com> <1744147477-23715-2-git-send-email-andremue@linux.microsoft.com> <20250409134210.GA24610@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250409134210.GA24610@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 09, 2025 at 06:42:10AM -0700, Andre Muezerie wrote: > On Wed, Apr 09, 2025 at 01:39:36PM +0200, David Marchand wrote: > > On Tue, Apr 8, 2025 at 11:24 PM Andre Muezerie > > wrote: > > > diff --git a/lib/net/meson.build b/lib/net/meson.build > > > index 7a6c419f40..c528fcc9a2 100644 > > > --- a/lib/net/meson.build > > > +++ b/lib/net/meson.build > > > @@ -43,7 +43,12 @@ use_function_versioning = true > > > > > > if dpdk_conf.has('RTE_ARCH_X86_64') > > > sources += files('net_crc_sse.c') > > > - cflags += ['-mpclmul', '-maes'] > > > + cflags_options = ['-mpclmul', '-maes'] > > > + foreach option:cflags_options > > > + if cc.has_argument(option) > > > + cflags += option > > > + endif > > > + endforeach > > > > What guarantee do we have that MSVC builds with those instructions? > > > > The granularity msvc offers for extended instruction sets is different. > I had sent a patch that allows DPDK code to benefit from those settings, > but it likely needs to be updated after recent changes were merged. I'll > revisit that in the next few days. > > For reference, here is what the original patch series looked like: > https://patches.dpdk.org/project/dpdk/list/?series=34803 > I checked the patch mentioned and confirmed that it still applies cleanly and that the build succeeds with the patch applied. It's ready to be reviewed. > > > # only build AVX-512 support if we also have PCLMULQDQ support > > > if cc.has_argument('-mvpclmulqdq') > > > sources_avx512 += files('net_crc_avx512.c') > > > > > > -- > > David Marchand