[PATCH 0/2] fix two nfp pmd bugs

[PATCH 0/2] fix two nfp pmd bugs

[Chaoyong He]

This patch series fix one coredump problem and one data over flow
problem.

Long Wu (2):
  net/nfp: fix flow rule free problem
  net/nfp: fix control message over flow problem

 drivers/net/nfp/nfp_net_cmsg.c | 3 ++-
 drivers/net/nfp/nfp_net_flow.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.43.5

[PATCH 1/2] net/nfp: fix flow rule free problem

[Chaoyong He]

From: Long Wu <long.wu@corigine.com>

The flow number limit is stored in `priv->flow_limit` now, so
the free index should be calculated based on it, or there will
be coredump problem.

Fixes: 66df893f2fef ("net/nfp: support different flow steering rules limit")
Cc: chaoyong.he@corigine.com
Cc: stable@dpdk.org

Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
---
 drivers/net/nfp/nfp_net_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_net_flow.c b/drivers/net/nfp/nfp_net_flow.c
index 7f3fff2186..0e5003ebe3 100644
--- a/drivers/net/nfp/nfp_net_flow.c
+++ b/drivers/net/nfp/nfp_net_flow.c
@@ -128,7 +128,7 @@ nfp_net_flow_position_free(struct nfp_net_priv *priv,
 {
 	uint32_t index;
 
-	index = NFP_NET_FLOW_LIMIT - 1 - nfp_flow->position;
+	index = priv->flow_limit - 1 - nfp_flow->position;
 
 	priv->flow_position[index] = false;
 }
-- 
2.43.5

[PATCH 2/2] net/nfp: fix control message over flow problem

[Chaoyong He]

From: Long Wu <long.wu@corigine.com>

Control message will send 32 bits data every time, so the number
of write operations should be adjust correctly, or there will be
over flow problem.

Fixes: ca65f2eef224 ("net/nfp: add control message channel")
Cc: chaoyong.he@corigine.com
Cc: stable@dpdk.org

Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
---
 drivers/net/nfp/nfp_net_cmsg.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_net_cmsg.c b/drivers/net/nfp/nfp_net_cmsg.c
index 8f77c5588a..1ebd66bb0f 100644
--- a/drivers/net/nfp/nfp_net_cmsg.c
+++ b/drivers/net/nfp/nfp_net_cmsg.c
@@ -36,8 +36,9 @@ nfp_net_cmsg_xmit(struct nfp_net_hw *hw,
 {
 	int ret;
 	uint32_t i;
+	uint32_t data_num = msg_size / sizeof(uint32_t);
 
-	for (i = 0; i < msg_size; i++)
+	for (i = 0; i < data_num; i++)
 		nn_cfg_writel(&hw->super, NFP_NET_CFG_MBOX_VAL + 4 * i, *((uint32_t *)cmsg + i));
 
 	ret = nfp_net_mbox_reconfig(hw, NFP_NET_CFG_MBOX_CMD_FLOW_STEER);
-- 
2.43.5