From: Stephen Hemminger <stephen@networkplumber.org>
To: liwencheng <liwencheng@phytium.com.cn>
Cc: dev@dpdk.org
Subject: Re: [PATCH v6 1/3] net/macb: add new poll mode driver
Date: Wed, 16 Apr 2025 09:38:32 -0700 [thread overview]
Message-ID: <20250416093832.43bef142@hermes.local> (raw)
In-Reply-To: <1744093201-313699-1-git-send-email-liwencheng@phytium.com.cn>
On Tue, 8 Apr 2025 06:20:01 +0000
liwencheng <liwencheng@phytium.com.cn> wrote:
> +
> + dev_num = rte_kvargs_count(kvlist, MACB_DEVICE_NAME_ARG);
> +
> + /* compatibility support */
> + if (!strcmp(vdev_name, "net_macb")) {
> + if (dev_num > MACB_MAX_PORT_NUM) {
> + ret = -EINVAL;
> + MACB_LOG(ERR, "number of devices exceeded. Maximum value: %d.",
> + MACB_MAX_PORT_NUM);
> + goto out_free_kvlist;
> + }
> + } else {
> + if (dev_num != 1) {
> + ret = -EINVAL;
> + MACB_LOG(ERR, "Error args: one vdev to one device.");
> + goto out_free_kvlist;
> + }
> + }
> +
Since this is to first merged version of the driver, confused about what
compatibility means in this context?
Does the driver require devargs to work? Isn't it a hardware driver.
next prev parent reply other threads:[~2025-04-16 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 6:58 [PATCH v4 2/4] " liwencheng
2025-04-03 1:43 ` Stephen Hemminger
2025-04-03 1:45 ` Stephen Hemminger
2025-04-07 6:38 ` [PATCH v5 " liwencheng
2025-04-08 6:20 ` [PATCH v6 1/3] " liwencheng
2025-04-16 16:38 ` Stephen Hemminger [this message]
2025-04-18 3:25 ` [PATCH v7 " Wencheng Li
2025-04-16 16:34 ` [PATCH v4 2/4] " Stephen Hemminger
2025-04-16 16:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416093832.43bef142@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liwencheng@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).