From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30C43465A9; Wed, 16 Apr 2025 16:03:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E5C74278A; Wed, 16 Apr 2025 16:00:55 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id BC2B741133 for ; Wed, 16 Apr 2025 16:00:48 +0200 (CEST) Received: from localhost.localdomain (unknown [78.109.65.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id D9A03E11C0; Wed, 16 Apr 2025 18:00:44 +0400 (+04) DKIM-Filter: OpenDKIM Filter v2.11.0 agw.arknetworks.am D9A03E11C0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arknetworks.am; s=default; t=1744812045; bh=7JvqhwecfCOkohmt/avlmpc4hsz6HDpZdtdvniHESDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eaQWQn3ITC13++mNmmXGQB8WgIUvI8/+eSln+es6fb/5JNNj0BTqarkCnNo9cZLZ/ 242c1MQwJRRLh6/HONO9YoTaMSItrUWQsY7Kq3ZZjAWe4gOSzuNh4OCdY9fI+R6oTF tVZPHMfRLC0rVBg5A30siKa4SrhsB35xO/A94Q6LI27xgJa24lI0qXVqt0rE5JKhOv KSRiwlVIVrojH+NuEgY9iKiwxFNLENv/t5Kl8LY5BaHtlqrrP8SFj6bwV7DvhWBwhv a/qE0hr6uChxKn3dXFXe20p7psgJiwpOmnioaSLjE5Sgjw4tqKq3X6454l3HHhNCEj meR7vQBZC54yQ== From: Ivan Malov To: dev@dpdk.org Cc: Andrew Rybchenko , Denis Pryazhennikov , Andy Moreton , Pieter Jansen Van Vuuren , Viacheslav Galaktionov Subject: [PATCH 23/46] common/sfc_efx/base: allow for const in MCDI struct accessor Date: Wed, 16 Apr 2025 17:59:53 +0400 Message-Id: <20250416140016.36127-24-ivan.malov@arknetworks.am> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250416140016.36127-1-ivan.malov@arknetworks.am> References: <20250416140016.36127-1-ivan.malov@arknetworks.am> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The existing code is fine, however, future patches will need to use this macro on buffers that are passed by callers with const qualifier. With 'cast-qual' enabled, this macro causes compile warnings in such cases. Rework it to allow for const. Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton Reviewed-by: Pieter Jansen Van Vuuren --- drivers/common/sfc_efx/base/efx_mcdi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/sfc_efx/base/efx_mcdi.h b/drivers/common/sfc_efx/base/efx_mcdi.h index f13bf43da6..4e82717015 100644 --- a/drivers/common/sfc_efx/base/efx_mcdi.h +++ b/drivers/common/sfc_efx/base/efx_mcdi.h @@ -536,7 +536,7 @@ efx_mcdi_set_nic_addr_regions( EFX_DWORD_1) << 32) #define MCDI_STRUCT_MEMBER(_buf, _type, _ofst) \ - ((_type *)((char *)_buf + _ofst ## _OFST)) \ + ((_type *)((char *)(uintptr_t)(_buf) + _ofst ## _OFST)) #define MCDI_STRUCT_BYTE(_buf, _ofst) \ EFX_BYTE_FIELD(*MCDI_STRUCT_MEMBER(_buf, efx_byte_t, _ofst), \ -- 2.39.5