From: Andre Muezerie <andremue@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 4/4] drivers: use macro to embed information in binaries
Date: Thu, 17 Apr 2025 10:10:38 -0700 [thread overview]
Message-ID: <20250417171038.GA11942@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20250415170517.6a7b37b4@hermes.local>
On Tue, Apr 15, 2025 at 05:05:17PM -0700, Stephen Hemminger wrote:
> On Mon, 14 Apr 2025 18:21:36 -0700
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
>
> > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> > index b7f02f56e1..a4cbe6f42f 100644
> > --- a/drivers/baseband/acc/rte_acc100_pmd.c
> > +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> > @@ -4082,9 +4082,9 @@ static struct rte_pci_driver acc100_pci_vf_driver = {
> > .drv_flags = RTE_PCI_DRV_NEED_MAPPING
> > };
> >
> > -RTE_PMD_REGISTER_PCI(ACC100PF_DRIVER_NAME, acc100_pci_pf_driver);
> > +RTE_PMD_REGISTER_PCI(ACC100PF_DRIVER_NAME, acc100_pci_pf_driver, __LINE__);
>
> Rather than changing so many drivers, can't you just use __LINE__ in the macro?
Yes, that's possible, and would be better. I sent out a V4 with these changes.
next prev parent reply other threads:[~2025-04-17 17:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 19:39 [PATCH 0/4] allow pmdinfo to be inserted and parsed using MSVC Andre Muezerie
2025-04-11 19:39 ` [PATCH 1/4] eal: add macro to embed information in binaries Andre Muezerie
2025-04-11 19:39 ` [PATCH 2/4] buildtools: use " Andre Muezerie
2025-04-11 20:07 ` Dmitry Kozlyuk
2025-04-11 19:39 ` [PATCH 3/4] usertools: parse strings from PE images Andre Muezerie
2025-04-11 20:09 ` Dmitry Kozlyuk
2025-04-11 19:39 ` [PATCH 4/4] drivers: use macro to embed information in binaries Andre Muezerie
2025-04-15 1:21 ` [PATCH v2 0/4] allow pmdinfo to be inserted and parsed using MSVC Andre Muezerie
2025-04-15 1:21 ` [PATCH v2 1/4] eal: add macro to embed information in binaries Andre Muezerie
2025-04-15 1:21 ` [PATCH v2 2/4] buildtools: use " Andre Muezerie
2025-04-15 7:44 ` Dmitry Kozlyuk
2025-04-15 14:36 ` Andre Muezerie
2025-04-15 1:21 ` [PATCH v2 3/4] usertools: parse strings from PE images Andre Muezerie
2025-04-15 11:19 ` Robin Jarry
2025-04-15 1:21 ` [PATCH v2 4/4] drivers: use macro to embed information in binaries Andre Muezerie
2025-04-16 0:05 ` Stephen Hemminger
2025-04-17 17:10 ` Andre Muezerie [this message]
2025-04-15 22:31 ` [PATCH v3 0/4] allow pmdinfo to be inserted and parsed using MSVC Andre Muezerie
2025-04-15 22:31 ` [PATCH v3 1/4] eal: add macro to embed information in binaries Andre Muezerie
2025-04-15 22:31 ` [PATCH v3 2/4] buildtools: use " Andre Muezerie
2025-04-15 22:31 ` [PATCH v3 3/4] usertools: parse strings from PE images Andre Muezerie
2025-04-15 22:31 ` [PATCH v3 4/4] drivers: use macro to embed information in binaries Andre Muezerie
2025-04-16 21:44 ` [PATCH v4 0/4] allow pmdinfo to be inserted and parsed using MSVC Andre Muezerie
2025-04-16 21:44 ` [PATCH v4 1/4] eal: add macro to embed information in binaries Andre Muezerie
2025-04-16 21:44 ` [PATCH v4 2/4] buildtools: use " Andre Muezerie
2025-04-16 21:44 ` [PATCH v4 3/4] usertools: parse strings from PE images Andre Muezerie
2025-04-16 21:44 ` [PATCH v4 4/4] drivers: use macro to embed information in binaries Andre Muezerie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417171038.GA11942@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).