RE: [PATCH v3 0/7] net/ena: release 2.13.0

RE: [PATCH v3 0/7] net/ena: release 2.13.0

[Brandes, Shai]

Hi Stephen, and apologies for the multiple patchsets.

We had a bug in our CI that prevented failed runs from showing up correctly in the report, this has just been identified and fixed.
While rechecking, we discovered that one of the patches in the latest v3 patchset is currently failing to compile. The problematic line was replaced in a later patch within the same set, so when applied as a whole, the series passed in our directed tests.

Problematic patch: [v3,4/7] net/ena: support fragment bypass mode https://patches.dpdk.org/project/dpdk/patch/20250522132614.3379-5-shaibran@amazon.com
Failure on the entire patchset is now visible under https://patches.dpdk.org/project/dpdk/patch/20250522133029.3575-1-shaibran@amazon.com/ 

Since we aim for each patch to compile independently, we'll need to abandon this patchset.
Could you please advise whether you'd prefer to abandon it yourself, since it's already marked as *Awaiting Upstream* and it appear on the remote "for-main" branch, or should we just change the state to *Superseded*?
Thanks again for your time and help!

Shai

> -----Original Message-----
> From: Brandes, Shai <shaibran@amazon.com>
> Sent: Thursday, May 22, 2025 4:26 PM
> To: stephen@networkplumber.org
> Cc: dev@dpdk.org; Brandes, Shai <shaibran@amazon.com>
> Subject: [PATCH v3 0/7] net/ena: release 2.13.0
> 
> This patchset includes an upgrade of the ENA HAL, introduces a new feature,
> and addresses three bug fixes.
> 
> Thank you in advance to the net maintainers and community members for
> your time and effort reviewing the code.
> 
> Best regards,
> Shai Brandes
> AWS Elastic Network Adapter team
> 
> ---
> v2:
> Removed patch "net/ena: fix virtual address calc for unaligned BARs"
> which contained a problematic casting when compiling with 32-bit system
> 
> v3:
> no change, there was some technical issue when sending the emails where
> part of the patches apeared on different series.
> 
> Shai Brandes (7):
>   net/ena/base: avoid recalculating desc per entry
>   net/ena/base: coding style changes
>   net/ena: separate doorbell logic for Rx and Tx
>   net/ena: support fragment bypass mode
>   net/ena: fix unhandled interrupt config failure
>   net/ena: fix aenq timeout with low poll interval
>   net/ena: upgrade driver version to 2.13.0
> 
>  doc/guides/nics/ena.rst                       | 13 ++-
>  doc/guides/rel_notes/release_25_07.rst        |  9 ++
>  drivers/net/ena/base/ena_com.c                | 39 +++++++-
>  drivers/net/ena/base/ena_com.h                |  8 ++
>  .../net/ena/base/ena_defs/ena_admin_defs.h    | 15 +++
>  drivers/net/ena/base/ena_eth_com.c            |  6 +-
>  drivers/net/ena/base/ena_eth_com.h            | 15 ++-
>  drivers/net/ena/ena_ethdev.c                  | 98 +++++++++++++++----
>  drivers/net/ena/ena_ethdev.h                  |  5 +-
>  9 files changed, 177 insertions(+), 31 deletions(-)
> 
> --
> 2.17.1

Re: [PATCH v3 0/7] net/ena: release 2.13.0

[Stephen Hemminger]

On Mon, 26 May 2025 14:13:27 +0000
"Brandes, Shai" <shaibran@amazon.com> wrote:

> Hi Stephen, and apologies for the multiple patchsets.
> 
> We had a bug in our CI that prevented failed runs from showing up correctly in the report, this has just been identified and fixed.
> While rechecking, we discovered that one of the patches in the latest v3 patchset is currently failing to compile. The problematic line was replaced in a later patch within the same set, so when applied as a whole, the series passed in our directed tests.
> 
> Problematic patch: [v3,4/7] net/ena: support fragment bypass mode https://patches.dpdk.org/project/dpdk/patch/20250522132614.3379-5-shaibran@amazon.com
> Failure on the entire patchset is now visible under https://patches.dpdk.org/project/dpdk/patch/20250522133029.3575-1-shaibran@amazon.com/ 
> 
> Since we aim for each patch to compile independently, we'll need to abandon this patchset.
> Could you please advise whether you'd prefer to abandon it yourself, since it's already marked as *Awaiting Upstream* and it appear on the remote "for-main" branch, or should we just change the state to *Superseded*?
> Thanks again for your time and help!
> 
> Shai

No worries, was relatively easy to update to the correct version.
Yeah, mark the latest correct version as Awaiting Upstream, and other should be Superseded.

[PATCH v3 0/7] net/ena: release 2.13.0

[Shai Brandes]

This patchset includes an upgrade of the ENA HAL,
introduces a new feature, and addresses three bug fixes.

Thank you in advance to the net maintainers and community members
for your time and effort reviewing the code.

Best regards,
Shai Brandes
AWS Elastic Network Adapter team

---
v2:
Removed patch "net/ena: fix virtual address calc for unaligned BARs"
which contained a problematic casting when compiling with 32-bit system

v3:
no change, there was some technical issue when sending the emails
where part of the patches apeared on different series.

Shai Brandes (7):
  net/ena/base: avoid recalculating desc per entry
  net/ena/base: coding style changes
  net/ena: separate doorbell logic for Rx and Tx
  net/ena: support fragment bypass mode
  net/ena: fix unhandled interrupt config failure
  net/ena: fix aenq timeout with low poll interval
  net/ena: upgrade driver version to 2.13.0

 doc/guides/nics/ena.rst                       | 13 ++-
 doc/guides/rel_notes/release_25_07.rst        |  9 ++
 drivers/net/ena/base/ena_com.c                | 39 +++++++-
 drivers/net/ena/base/ena_com.h                |  8 ++
 .../net/ena/base/ena_defs/ena_admin_defs.h    | 15 +++
 drivers/net/ena/base/ena_eth_com.c            |  6 +-
 drivers/net/ena/base/ena_eth_com.h            | 15 ++-
 drivers/net/ena/ena_ethdev.c                  | 98 +++++++++++++++----
 drivers/net/ena/ena_ethdev.h                  |  5 +-
 9 files changed, 177 insertions(+), 31 deletions(-)

-- 
2.17.1