DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dhanya Pillai <dhanya.r.pillai@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org,
	Janardhanan Arumugam <janardhanan.arumugam@intel.com>,
	Dhanya Pillai <dhanya.r.pillai@intel.com>
Subject: [PATCH 9/9] net/ice/base: increase reset timeout to 20 seconds
Date: Mon, 26 May 2025 08:33:11 +0000	[thread overview]
Message-ID: <20250526083325.248384-10-dhanya.r.pillai@intel.com> (raw)
In-Reply-To: <20250526083325.248384-1-dhanya.r.pillai@intel.com>

From: Janardhanan Arumugam <janardhanan.arumugam@intel.com>

Resets on E830 hardware can take longer than 5 seconds to complete due
to E830 security keys functionality. The current timeout may be too
short, leading to reset failures.

Increase the reset timeout by updating ICE_PF_RESET_WAIT_COUNT, changing
the maximum wait time from 5 seconds to 20 seconds.

This change applies to all hardware, but since the driver polls the
reset done bits every 10 milliseconds this does not affect reset time on
non-E830 devices where the reset completes quicker.

Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
---
 drivers/net/intel/ice/base/ice_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/intel/ice/base/ice_common.c b/drivers/net/intel/ice/base/ice_common.c
index 9ba656d8ec..4de9f37989 100644
--- a/drivers/net/intel/ice/base/ice_common.c
+++ b/drivers/net/intel/ice/base/ice_common.c
@@ -9,7 +9,7 @@
 #include "ice_ptp_hw.h"
 #include "ice_switch.h"
 
-#define ICE_PF_RESET_WAIT_COUNT	500
+#define ICE_PF_RESET_WAIT_COUNT	2000
 
 static const char * const ice_link_mode_str_low[] = {
 	ice_arr_elem_idx(0, "100BASE_TX"),
-- 
2.43.0


      parent reply	other threads:[~2025-05-26  8:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-26  8:33 [PATCH 0/9] Update ICE base code Dhanya Pillai
2025-05-26  8:33 ` [PATCH 1/9] net/ice/base: type conversion fix Dhanya Pillai
2025-05-26  8:33 ` [PATCH 2/9] net/ice/base: typo fix in media type check Dhanya Pillai
2025-05-26  8:33 ` [PATCH 3/9] net/ice/base: integer overflow issue fix Dhanya Pillai
2025-05-26  8:33 ` [PATCH 4/9] net/ice/base: set speculative execution barrier Dhanya Pillai
2025-05-26  8:33 ` [PATCH 5/9] net/ice/base: typo fix in desc for dev ID 579F Dhanya Pillai
2025-05-26  8:33 ` [PATCH 6/9] net/ice/base: ptp minimal refactoring Dhanya Pillai
2025-05-26  8:33 ` [PATCH 7/9] net/ice/base: support for MAC rule with own filter flags Dhanya Pillai
2025-05-26  8:33 ` [PATCH 8/9] net/ice/base: configure PHY FEC error in logs for GNRD Dhanya Pillai
2025-05-26  8:33 ` Dhanya Pillai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250526083325.248384-10-dhanya.r.pillai@intel.com \
    --to=dhanya.r.pillai@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=janardhanan.arumugam@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).