DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dhanya Pillai <dhanya.r.pillai@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Oleg Akhrem <oleg.akhrem@intel.com>,
	Dhanya Pillai <dhanya.r.pillai@intel.com>
Subject: [PATCH 6/9] net/ice/base: ptp minimal refactoring
Date: Mon, 26 May 2025 08:33:08 +0000	[thread overview]
Message-ID: <20250526083325.248384-7-dhanya.r.pillai@intel.com> (raw)
In-Reply-To: <20250526083325.248384-1-dhanya.r.pillai@intel.com>

From: Oleg Akhrem <oleg.akhrem@intel.com>

Removed redundant code. The *clk_freq and *clk_src are not modified.

Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
---
 drivers/net/intel/ice/base/ice_ptp_hw.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/intel/ice/base/ice_ptp_hw.c b/drivers/net/intel/ice/base/ice_ptp_hw.c
index 1e92e5ff21..7d16965674 100644
--- a/drivers/net/intel/ice/base/ice_ptp_hw.c
+++ b/drivers/net/intel/ice/base/ice_ptp_hw.c
@@ -520,9 +520,6 @@ ice_cfg_cgu_pll_e825c(struct ice_hw *hw, enum ice_time_ref_freq *clk_freq,
 		  ice_clk_src_str(dw23.field.time_ref_sel),
 		  ice_clk_freq_str(dw9.field.time_ref_freq_sel));
 
-	*clk_freq = (enum ice_time_ref_freq)dw9.field.time_ref_freq_sel;
-	*clk_src = (enum ice_clk_src)dw23.field.time_ref_sel;
-
 	return 0;
 }
 
@@ -798,11 +795,11 @@ static int ice_init_cgu_e82x(struct ice_hw *hw)
 		ice_warn(hw, "Failed to lock TS PLL to predefined frequency. Retrying with fallback frequency.\n");
 
 		/* Try to lock to internal 25 MHz TCXO as a fallback */
+		time_ref_freq = ICE_TIME_REF_FREQ_25_000;
+		clk_src = ICE_CLK_SRC_TCX0;
 		if (hw->phy_model == ICE_PHY_ETH56G)
 			time_ref_freq = ICE_TIME_REF_FREQ_156_250;
-		else
-			time_ref_freq = ICE_TIME_REF_FREQ_25_000;
-		clk_src = ICE_CLK_SRC_TCX0;
+
 		if (ice_is_e825c(hw))
 			err = ice_cfg_cgu_pll_e825c(hw, &time_ref_freq,
 						    &clk_src);
-- 
2.43.0


  parent reply	other threads:[~2025-05-26  8:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-26  8:33 [PATCH 0/9] Update ICE base code Dhanya Pillai
2025-05-26  8:33 ` [PATCH 1/9] net/ice/base: type conversion fix Dhanya Pillai
2025-05-26  8:33 ` [PATCH 2/9] net/ice/base: typo fix in media type check Dhanya Pillai
2025-05-26  8:33 ` [PATCH 3/9] net/ice/base: integer overflow issue fix Dhanya Pillai
2025-05-26  8:33 ` [PATCH 4/9] net/ice/base: set speculative execution barrier Dhanya Pillai
2025-05-26  8:33 ` [PATCH 5/9] net/ice/base: typo fix in desc for dev ID 579F Dhanya Pillai
2025-05-26  8:33 ` Dhanya Pillai [this message]
2025-05-26  8:33 ` [PATCH 7/9] net/ice/base: support for MAC rule with own filter flags Dhanya Pillai
2025-05-26  8:33 ` [PATCH 8/9] net/ice/base: configure PHY FEC error in logs for GNRD Dhanya Pillai
2025-05-26  8:33 ` [PATCH 9/9] net/ice/base: increase reset timeout to 20 seconds Dhanya Pillai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250526083325.248384-7-dhanya.r.pillai@intel.com \
    --to=dhanya.r.pillai@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=oleg.akhrem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).