From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60541467F2; Mon, 26 May 2025 10:34:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9917C4069D; Mon, 26 May 2025 10:34:20 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 89E6040697 for ; Mon, 26 May 2025 10:34:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748248452; x=1779784452; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8ytuUQSaS+otvO2MOfF2F6zZ06GoQUbNC4Eh5pLovmk=; b=L+myFDm9oLrXnC5viZOaSmqg4aoNVwd359L5ZV/QFUxOGBVNAQngORGs VPvn6clBn1A5shHtgnT2g91qBovw14dDm27En+jPmx9n1NHKgdUthqEcA 2MnxzwRZ6Y0mkwO2y84FTOZXvTo3ib5Q1AgaeGubjZyP8V/pWMDlWhVM1 22OSNU2vaZn6spnLm0NSvbKAoeJZq/ZYtVx7HHJa8nZme0hvH/0dwBc2e 47umixTlC+YieXjjXOvACHsS3ZtW77eX4mJNE3ZtrUneRI53qOybe3wjQ Gai8LeSF8cTKNBg8iOMXEgP540ezSLf2oLjzhSjYFYisM2km9CIm0sEZa w==; X-CSE-ConnectionGUID: xbNyPP15RkSL3H1UVBrUGQ== X-CSE-MsgGUID: keLLK5dtTf+ihs8IB/cDWQ== X-IronPort-AV: E=McAfee;i="6700,10204,11444"; a="54009044" X-IronPort-AV: E=Sophos;i="6.15,315,1739865600"; d="scan'208";a="54009044" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2025 01:34:12 -0700 X-CSE-ConnectionGUID: iB7xwAXIR0SqU5cI705Otg== X-CSE-MsgGUID: yst4hsDqTRGaDwuBxJcwog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,315,1739865600"; d="scan'208";a="142293590" Received: from unknown (HELO silpixa00401120.ir.intel.com) ([10.55.128.58]) by fmviesa007.fm.intel.com with ESMTP; 26 May 2025 01:34:11 -0700 From: Dhanya Pillai To: Bruce Richardson , Anatoly Burakov Cc: dev@dpdk.org, "Filar, Mikolaj" , Dhanya Pillai Subject: [PATCH 7/9] net/ice/base: support for MAC rule with own filter flags Date: Mon, 26 May 2025 08:33:09 +0000 Message-ID: <20250526083325.248384-8-dhanya.r.pillai@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250526083325.248384-1-dhanya.r.pillai@intel.com> References: <20250526083325.248384-1-dhanya.r.pillai@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: "Filar, Mikolaj" Current implementation of ice_add_mac_rule overwrites flags passed in fltr_info member of the m_list with ICE_FLTR_TX. This implementation allows to use own flags with a new ice_add_mac_with_fltr_flag function. No functional change in MAC filters. Signed-off-by: Dhanya Pillai --- drivers/net/intel/ice/base/ice_switch.c | 46 ++++++++++++++++++++++--- drivers/net/intel/ice/base/ice_switch.h | 1 + 2 files changed, 43 insertions(+), 4 deletions(-) diff --git a/drivers/net/intel/ice/base/ice_switch.c b/drivers/net/intel/ice/base/ice_switch.c index 468a9f055d..777fc88d01 100644 --- a/drivers/net/intel/ice/base/ice_switch.c +++ b/drivers/net/intel/ice/base/ice_switch.c @@ -5112,11 +5112,12 @@ ice_aq_get_res_descs(struct ice_hw *hw, u16 num_entries, } /** - * ice_add_mac_rule - Add a MAC address based filter rule + * ice_add_mac_rule_with_fltr_flag - Add a MAC address based filter rule * @hw: pointer to the hardware structure * @m_list: list of MAC addresses and forwarding information * @sw: pointer to switch info struct for which function add rule * @lport: logic port number on which function add rule + * @flag: filter flag * * IMPORTANT: When the umac_shared flag is set to false and m_list has * multiple unicast addresses, the function assumes that all the @@ -5125,8 +5126,8 @@ ice_aq_get_res_descs(struct ice_hw *hw, u16 num_entries, * list should be taken care of in the caller of this function. */ static int -ice_add_mac_rule(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list, - struct ice_switch_info *sw, u8 lport) +ice_add_mac_rule_with_fltr_flag(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list, + struct ice_switch_info *sw, u8 lport, u16 flag) { struct ice_sw_recipe *recp_list = &sw->recp_list[ICE_SW_LKUP_MAC]; struct ice_sw_rule_lkup_rx_tx *s_rule, *r_iter; @@ -5148,7 +5149,7 @@ ice_add_mac_rule(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list, u16 vsi_handle; u16 hw_vsi_id; - m_list_itr->fltr_info.flag = ICE_FLTR_TX; + m_list_itr->fltr_info.flag = flag; vsi_handle = m_list_itr->fltr_info.vsi_handle; if (!ice_is_vsi_valid(hw, vsi_handle)) return ICE_ERR_PARAM; @@ -5268,6 +5269,26 @@ ice_add_mac_rule(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list, return status; } +/** + * ice_add_mac_rule - Add a MAC address based filter rule + * @hw: pointer to the hardware structure + * @m_list: list of MAC addresses and forwarding information + * @sw: pointer to switch info struct for which function add rule + * @lport: logic port number on which function add rule + * + * IMPORTANT: When the umac_shared flag is set to false and m_list has + * multiple unicast addresses, the function assumes that all the + * addresses are unique in a given add_mac call. It doesn't + * check for duplicates in this case, removing duplicates from a given + * list should be taken care of in the caller of this function. + */ +static int +ice_add_mac_rule(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list, + struct ice_switch_info *sw, u8 lport) +{ + return ice_add_mac_rule_with_fltr_flag(hw, m_list, sw, lport, ICE_FLTR_TX); +} + /** * ice_add_mac - Add a MAC address based filter rule * @hw: pointer to the hardware structure @@ -5284,6 +5305,23 @@ int ice_add_mac(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list) hw->port_info->lport); } +/** + * ice_add_mac_with_fltr_flag - Add a MAC address based filter rule + * @hw: pointer to the hardware structure + * @m_list: list of MAC addresses and forwarding information + * @flag: filter flag + * + * Function add MAC rule for logical port from HW struct + */ +int ice_add_mac_with_fltr_flag(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list, u16 flag) +{ + if (!m_list || !hw) + return ICE_ERR_PARAM; + + return ice_add_mac_rule_with_fltr_flag(hw, m_list, hw->switch_info, + hw->port_info->lport, flag); +} + /** * ice_add_vlan_internal - Add one VLAN based filter rule * @hw: pointer to the hardware structure diff --git a/drivers/net/intel/ice/base/ice_switch.h b/drivers/net/intel/ice/base/ice_switch.h index 00bffe4e4e..8eac7739fb 100644 --- a/drivers/net/intel/ice/base/ice_switch.h +++ b/drivers/net/intel/ice/base/ice_switch.h @@ -548,6 +548,7 @@ ice_add_vlan(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list); int ice_remove_vlan(struct ice_hw *hw, struct LIST_HEAD_TYPE *v_list); void ice_rem_all_sw_rules_info(struct ice_hw *hw); int ice_add_mac(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_lst); +int ice_add_mac_with_fltr_flag(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list, u16 flag); int ice_remove_mac(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_lst); int ice_add_eth_mac(struct ice_hw *hw, struct LIST_HEAD_TYPE *em_list); -- 2.43.0