From: Dhanya Pillai <dhanya.r.pillai@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Lukasz Krakowiak <lukaszx.krakowiak@intel.com>,
Dhanya Pillai <dhanya.r.pillai@intel.com>
Subject: [PATCH v2 03/10] net/ice/base: integer overflow issue fix
Date: Mon, 26 May 2025 18:02:51 +0000 [thread overview]
Message-ID: <20250526180311.4573-4-dhanya.r.pillai@intel.com> (raw)
In-Reply-To: <20250526180311.4573-1-dhanya.r.pillai@intel.com>
From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Fix Coverity issue related to INTEGER_OVERFLOW.
Coverity issue: 1207097
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
---
drivers/net/intel/ice/base/ice_type.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/intel/ice/base/ice_type.h b/drivers/net/intel/ice/base/ice_type.h
index 297a5ea890..757b1d7658 100644
--- a/drivers/net/intel/ice/base/ice_type.h
+++ b/drivers/net/intel/ice/base/ice_type.h
@@ -25,7 +25,7 @@
*/
static inline bool ice_is_pow2(u64 val)
{
- return (val && !(val & (val - 1)));
+ return val != 0 && (val & (val -1)) == 0;
}
/**
--
2.43.0
next prev parent reply other threads:[~2025-05-26 18:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 18:02 [PATCH v2 00/10] Update ice base code Dhanya Pillai
2025-05-26 18:02 ` [PATCH v2 01/10] net/ice/base: type conversion fix Dhanya Pillai
2025-05-26 18:02 ` [PATCH v2 02/10] net/ice/base: typo fix in media type check Dhanya Pillai
2025-05-26 18:02 ` Dhanya Pillai [this message]
2025-05-26 18:02 ` [PATCH v2 04/10] net/ice/base: set speculative execution barrier Dhanya Pillai
2025-05-26 18:02 ` [PATCH v2 05/10] net/ice/base: typo fix in desc for dev ID 579F Dhanya Pillai
2025-05-26 18:02 ` [PATCH v2 06/10] net/ice/base: ptp minimal refactoring Dhanya Pillai
2025-05-26 18:02 ` [PATCH v2 07/10] net/ice/base: support for MAC rule with own filter flags Dhanya Pillai
2025-05-26 18:02 ` [PATCH v2 08/10] net/ice/base: configure PHY FEC error in logs for GNRD Dhanya Pillai
2025-05-26 18:02 ` [PATCH v2 09/10] net/ice/base: increase reset timeout to 20 seconds Dhanya Pillai
2025-05-26 18:02 ` [PATCH v2 10/10] net/ice/base: update version info Dhanya Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250526180311.4573-4-dhanya.r.pillai@intel.com \
--to=dhanya.r.pillai@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=lukaszx.krakowiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).