From: Stephen Hemminger <stephen@networkplumber.org>
To: vanshika.shukla@nxp.com
Cc: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>,
Jun Yang <jun.yang@nxp.com>
Subject: Re: [v1 01/10] bus/dpaa: avoid using same structure and variable name
Date: Wed, 28 May 2025 07:26:49 -0700 [thread overview]
Message-ID: <20250528072649.3f534c55@hermes.local> (raw)
In-Reply-To: <20250528115513.1023689-2-vanshika.shukla@nxp.com>
On Wed, 28 May 2025 17:25:04 +0530
vanshika.shukla@nxp.com wrote:
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> rte_dpaa_bus was being used as structure and variable name both.
>
> Signed-off-by: Jun Yang <jun.yang@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
That is perfectly ok in C.
Would prefer that you not use rte_ for variable names that are
local to the driver.
next prev parent reply other threads:[~2025-05-28 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 11:55 [v1 00/10] DPAA specific fixes vanshika.shukla
2025-05-28 11:55 ` [v1 01/10] bus/dpaa: avoid using same structure and variable name vanshika.shukla
2025-05-28 14:26 ` Stephen Hemminger [this message]
2025-05-28 14:25 ` [v1 00/10] DPAA specific fixes Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2025-05-28 10:39 vanshika.shukla
2025-05-28 10:39 ` [v1 01/10] bus/dpaa: avoid using same structure and variable name vanshika.shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528072649.3f534c55@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jun.yang@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=vanshika.shukla@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).