Re: [PATCH v4 0/4] allow pmdinfo to be inserted and parsed using MSVC

[Andre Muezerie <andremue@linux.microsoft.com>]

On Wed, Apr 16, 2025 at 02:44:54PM -0700, Andre Muezerie wrote:
> DPDK uses GCC attribute "used" through macro __rte_used to indicate
> that a variable not referenced in the code should be assumed being
> used and therefore not be optimized away. This technique is used to embed
> information in the binaries, by having crafted information stored in
> them.
> 
> MSVC offers similar functionality, but it differs significantly: MSVC
> requires a pragma to be used to send a command to the linker telling it
> explicitly the name of the symbol that should be included (even if not
> referenced). As a side-effect, variables called out to be included cannot
> be static, otherwise their symbols are not "seen" by the linker. This
> restriction requires some DPDK code to be refactored.
> 
> Macro RTE_INCLUDE is used in this patch to ensure these special variables
> make it to the final binaries.
> 
> The elimination of "static" for some of these variables caused name
> clashes when __COUNTER__ predefined macro was used. As a workaround,
> predefined macro __LINE__ was used instead. However, when __COUNTER__
> was used directly from a header file, __LINE__ had to be used from the
> .c files, otherwise it would also not result in a unique symbol. This
> required a parameter to be added to some macros so that the __LINE__
> could be passed from the .c file to the macro defined in the header
> (which was originally using __COUNTER__).
> 
> With this patchset commands like the one below provide the same JSON
> output as would be obtained on Linux.
> 
> python usertools\dpdk-pmdinfo.py build\app\dpdk-testpmd.exe
> 
> v4:
>  - limited the use of __LINE__ to the header files, reducing number of
>    changes made in previous versions of this patchset.
> 
> v3:
>  - ge-pmdinfo-cfile.py: fixed archiver's syntax to extract object from
>    library
>  - dpdk-pmdinfo.py: removed is_windows() and replaced with
>    os.name == "nt"
> 
> v2:
>  - dpdk-pmdinfo.py: not importing elftools on Windows
>  - not requiring "pefile" Python module during build
>  - gen-pmdinfo-cfile.py: renamed "ar" to "archiver"
> 
> Andre Muezerie (4):
>   eal: add macro to embed information in binaries
>   buildtools: use macro to embed information in binaries
>   usertools: parse strings from PE images
>   drivers: use macro to embed information in binaries
> 
>  buildtools/gen-pmdinfo-cfile.py              | 24 +++++++--
>  buildtools/meson.build                       |  4 +-
>  buildtools/pmdinfogen.py                     | 11 ++--
>  drivers/bus/auxiliary/bus_auxiliary_driver.h |  2 +-
>  drivers/bus/cdx/bus_cdx_driver.h             |  5 +-
>  drivers/bus/dpaa/bus_dpaa_driver.h           |  2 +-
>  drivers/bus/fslmc/bus_fslmc_driver.h         |  4 +-
>  drivers/bus/ifpga/bus_ifpga_driver.h         |  2 +-
>  drivers/bus/pci/bus_pci_driver.h             |  2 +-
>  drivers/bus/platform/bus_platform_driver.h   |  2 +-
>  drivers/bus/uacce/bus_uacce_driver.h         |  2 +-
>  drivers/bus/vdev/bus_vdev_driver.h           |  2 +-
>  drivers/bus/vmbus/bus_vmbus_driver.h         |  2 +-
>  drivers/common/mlx5/mlx5_common.c            |  2 +-
>  drivers/common/mlx5/mlx5_common_pci.c        |  2 +-
>  drivers/common/nitrox/nitrox_device.c        |  1 +
>  drivers/compress/mlx5/mlx5_compress.c        |  2 +-
>  drivers/crypto/mlx5/mlx5_crypto.c            |  2 +-
>  drivers/event/octeontx/ssovf_evdev.c         |  1 +
>  drivers/net/mlx4/mlx4.c                      |  2 +-
>  drivers/net/mlx5/mlx5.c                      |  2 +-
>  drivers/net/virtio/virtio_pci_ethdev.c       |  2 +-
>  drivers/regex/mlx5/mlx5_regex.c              |  2 +-
>  drivers/vdpa/mlx5/mlx5_vdpa.c                |  2 +-
>  lib/eal/common/eal_common_options.c          |  2 +-
>  lib/eal/include/rte_common.h                 |  6 +++
>  lib/eal/include/rte_dev.h                    | 14 ++----
>  usertools/dpdk-pmdinfo.py                    | 53 ++++++++++++++++----
>  28 files changed, 106 insertions(+), 53 deletions(-)
> 
> --
> 2.49.0.vfs.0.0

Would someone be able to review this series?
Thanks,

Andre Muezerie