From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C07494685A; Tue, 3 Jun 2025 03:07:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94C2A4028E; Tue, 3 Jun 2025 03:07:31 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id A73C74025A for ; Tue, 3 Jun 2025 03:07:29 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1213) id 953DA2113A62; Mon, 2 Jun 2025 18:07:28 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 953DA2113A62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1748912848; bh=nelYCBzgICJrXGPLj125DTiWrIL6MsRNrPSiA0OTaeU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Djyb6V0HlrEeBP7xPoJvQOWAl2zqQtLTFesZ8AZg8ck4ejIU102fETp1PsxUw5qtW dk6xOwwQ+nlyuMeqxnZQBMmGZDHojyqAEiOwpfY4AFtjpyXgy3YYai9IIe8xP+2NSQ pLZJLyLKHcpG7qHgGIuO5/M3Cgz0Qk2wLhZsY9tI= Date: Mon, 2 Jun 2025 18:07:28 -0700 From: Andre Muezerie To: Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad Cc: dev@dpdk.org Subject: Re: [PATCH] common/mlx5: use intrinsics instead of inline assembly Message-ID: <20250603010728.GC30135@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1746457062-8502-1-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1746457062-8502-1-git-send-email-andremue@linux.microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 05, 2025 at 07:57:42AM -0700, Andre Muezerie wrote: > When compiling with MSVC the errors below are hit because msvc does not > support inline assembly: > > 1) > ../drivers/common/mlx5/mlx5_common.c(86): warning C4013: '__asm__' > undefined; assuming extern returning int > ../drivers/common/mlx5/mlx5_common.c(87): error C2143: syntax error: > missing ')' before ':' > > 2) > ../drivers/net/mlx5/mlx5_txpp.c(510): error C2065: '__asm__': > undeclared identifier > ../drivers/net/mlx5/mlx5_txpp.c(510): error C2143: syntax error: > missing ';' before 'volatile' > > The fix for (1) is to use compiler intrinsic __cpuid and for (2) > intrinsic _InterlockedCompareExchange128 can be used. > > Signed-off-by: Andre Muezerie > --- > drivers/common/mlx5/mlx5_common.c | 13 +++++++++++-- > drivers/net/mlx5/mlx5_txpp.c | 15 +++++++++++++++ > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c > index 4f25127582..e1ce17559d 100644 > --- a/drivers/common/mlx5/mlx5_common.c > +++ b/drivers/common/mlx5/mlx5_common.c > @@ -75,9 +75,18 @@ static inline void mlx5_cpu_id(unsigned int level, > unsigned int *eax, unsigned int *ebx, > unsigned int *ecx, unsigned int *edx) > { > +#ifdef RTE_TOOLCHAIN_MSVC > + int data[4]; > + __cpuid(data, level); > + *eax = data[0]; > + *ebx = data[1]; > + *ecx = data[2]; > + *edx = data[3]; > +#else > __asm__("cpuid\n\t" > - : "=a" (*eax), "=b" (*ebx), "=c" (*ecx), "=d" (*edx) > - : "0" (level)); > + : "=a" (*eax), "=b" (*ebx), "=c" (*ecx), "=d" (*edx) > + : "0" (level)); > +#endif > } > #endif > > diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c > index e6d3ad83e9..5bbaf668e6 100644 > --- a/drivers/net/mlx5/mlx5_txpp.c > +++ b/drivers/net/mlx5/mlx5_txpp.c > @@ -486,6 +486,20 @@ mlx5_txpp_cq_arm(struct mlx5_dev_ctx_shared *sh) > } > > #if defined(RTE_ARCH_X86_64) > +#ifdef RTE_TOOLCHAIN_MSVC > +static inline int > +mlx5_atomic128_compare_exchange(rte_int128_t *dst, > + rte_int128_t *exp, > + const rte_int128_t *src) > +{ > + return (int)_InterlockedCompareExchange128( > + (int64_t volatile *)dst, > + src->val[1], /* exchange high */ > + src->val[0], /* exchange low */ > + (int64_t *)exp /* comparand result */ > + ); > +} > +#else > static inline int > mlx5_atomic128_compare_exchange(rte_int128_t *dst, > rte_int128_t *exp, > @@ -510,6 +524,7 @@ mlx5_atomic128_compare_exchange(rte_int128_t *dst, > return res; > } > #endif > +#endif > > static inline void > mlx5_atomic_read_cqe(rte_int128_t *from, rte_int128_t *ts) > -- > 2.49.0.vfs.0.2 Would someone be able to review this patchset? Thanks, Andre Muezerie