* [PATCH] drivers/net/mlx5: fix mlx5 send packet failed
@ 2025-03-25 10:39 Wenbo Liu
2025-03-25 14:10 ` Stephen Hemminger
2025-06-03 14:49 ` Dariusz Sosnowski
0 siblings, 2 replies; 3+ messages in thread
From: Wenbo Liu @ 2025-03-25 10:39 UTC (permalink / raw)
To: rasland; +Cc: dev, Wenbo Liu
Test Environment: ARM architecture, OpenEuler operating system
CPU: HUAWEI Kunpeng 920 5220, BIOS Vendor ID: HiSilicon
Network Card: Mellanox Technologies MT27800 Family [ConnectX-5]
DPDK program sending self-encapsulated packets with MAC, IP, and UDP headers
continuously prints the following errors and ceases packet transmission
mlx5_common: Failed to modify SQ using DevX
mlx5_net: Cannot change the Tx SQ state to RESET Remote I/O error
Signed-off-by: Wenbo Liu <liuwenbo109@gmail.com>
---
drivers/net/mlx5/mlx5_tx.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c
index 4286876..5cf9873 100644
--- a/drivers/net/mlx5/mlx5_tx.c
+++ b/drivers/net/mlx5/mlx5_tx.c
@@ -186,6 +186,7 @@
volatile struct mlx5_cqe *last_cqe = NULL;
bool ring_doorbell = false;
int ret;
+ int offset = 0;
do {
volatile struct mlx5_cqe *cqe;
@@ -205,8 +206,11 @@
* here, before we might perform SQ reset.
*/
rte_wmb();
+#if (RTE_CACHE_LINE_SIZE == 128)
+ offset = 64;
+#endif
ret = mlx5_tx_error_cqe_handle
- (txq, (volatile struct mlx5_error_cqe *)cqe);
+ (txq, (volatile struct mlx5_err_cqe *)(((char *)cqe) + offset));
if (unlikely(ret < 0)) {
/*
* Some error occurred on queue error
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/mlx5: fix mlx5 send packet failed
2025-03-25 10:39 [PATCH] drivers/net/mlx5: fix mlx5 send packet failed Wenbo Liu
@ 2025-03-25 14:10 ` Stephen Hemminger
2025-06-03 14:49 ` Dariusz Sosnowski
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2025-03-25 14:10 UTC (permalink / raw)
To: Wenbo Liu; +Cc: rasland, dev
On Tue, 25 Mar 2025 18:39:00 +0800
Wenbo Liu <liuwenbo109@gmail.com> wrote:
> Test Environment: ARM architecture, OpenEuler operating system
> CPU: HUAWEI Kunpeng 920 5220, BIOS Vendor ID: HiSilicon
> Network Card: Mellanox Technologies MT27800 Family [ConnectX-5]
> DPDK program sending self-encapsulated packets with MAC, IP, and UDP headers
> continuously prints the following errors and ceases packet transmission
>
> mlx5_common: Failed to modify SQ using DevX
> mlx5_net: Cannot change the Tx SQ state to RESET Remote I/O error
>
> Signed-off-by: Wenbo Liu <liuwenbo109@gmail.com>
Patch has compile failures in CI and coding indent issue reported by checkpatch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/mlx5: fix mlx5 send packet failed
2025-03-25 10:39 [PATCH] drivers/net/mlx5: fix mlx5 send packet failed Wenbo Liu
2025-03-25 14:10 ` Stephen Hemminger
@ 2025-06-03 14:49 ` Dariusz Sosnowski
1 sibling, 0 replies; 3+ messages in thread
From: Dariusz Sosnowski @ 2025-06-03 14:49 UTC (permalink / raw)
To: Wenbo Liu; +Cc: rasland, dev, viacheslavo, bingz, orika, suanmingm, matan
Hi,
Adding all mlx5 maintainers.
On Tue, Mar 25, 2025 at 06:39:00PM +0800, Wenbo Liu wrote:
> Test Environment: ARM architecture, OpenEuler operating system
> CPU: HUAWEI Kunpeng 920 5220, BIOS Vendor ID: HiSilicon
> Network Card: Mellanox Technologies MT27800 Family [ConnectX-5]
> DPDK program sending self-encapsulated packets with MAC, IP, and UDP headers
> continuously prints the following errors and ceases packet transmission
>
> mlx5_common: Failed to modify SQ using DevX
> mlx5_net: Cannot change the Tx SQ state to RESET Remote I/O error
>
> Signed-off-by: Wenbo Liu <liuwenbo109@gmail.com>
> ---
> drivers/net/mlx5/mlx5_tx.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c
> index 4286876..5cf9873 100644
> --- a/drivers/net/mlx5/mlx5_tx.c
> +++ b/drivers/net/mlx5/mlx5_tx.c
> @@ -186,6 +186,7 @@
> volatile struct mlx5_cqe *last_cqe = NULL;
> bool ring_doorbell = false;
> int ret;
> + int offset = 0;
>
> do {
> volatile struct mlx5_cqe *cqe;
> @@ -205,8 +206,11 @@
> * here, before we might perform SQ reset.
> */
> rte_wmb();
> +#if (RTE_CACHE_LINE_SIZE == 128)
> + offset = 64;
> +#endif
> ret = mlx5_tx_error_cqe_handle
> - (txq, (volatile struct mlx5_error_cqe *)cqe);
> + (txq, (volatile struct mlx5_err_cqe *)(((char *)cqe) + offset));
Could you please elaborate what exactly that changes?
I think I'm missing something.
mlx5_error_cqe, used here originally, takes into account the
possibility of cache line being 128B
(https://github.com/DPDK/dpdk/blob/main/drivers/common/mlx5/mlx5_prm.h#L427)
and this achieves the equivalent to the above diff.
> if (unlikely(ret < 0)) {
> /*
> * Some error occurred on queue error
> --
> 1.8.3.1
>
Best regards,
Dariusz Sosnowski
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-03 14:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-25 10:39 [PATCH] drivers/net/mlx5: fix mlx5 send packet failed Wenbo Liu
2025-03-25 14:10 ` Stephen Hemminger
2025-06-03 14:49 ` Dariusz Sosnowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).