From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>, <dev@dpdk.org>
Subject: Re: [PATCH 1/1] net/mlx5: unresolved symbol mlx5_geneve_tlv_parser_create
Date: Tue, 3 Jun 2025 16:57:09 +0200 [thread overview]
Message-ID: <20250603145709.wtlv3stxqbblduoa@ds-vm-debian.local> (raw)
In-Reply-To: <1746456337-6278-2-git-send-email-andremue@linux.microsoft.com>
Hi,
On Mon, May 05, 2025 at 07:45:37AM -0700, Andre Muezerie wrote:
> When compiling DPDK with mlx5 using clang on Windows with
> "debug" buildtype the error below is hit:
>
> net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol
> mlx5_geneve_tlv_parser_create referenced in function
> flow_dv_discover_priorities
> drivers\rte_net_mlx5-25.dll : fatal error LNK1120: 1 unresolved externals
>
> With a "release" buildtype the error is not seen, which explains why this
> issue was not reported earlier.
>
> The same problem will show up with MSVC, but patches which are still under
> review are needed for this to be hit with MSVC.
>
> The cause of this problem seems to be that mlx5_flow_geneve.c is only
> compiled on Linux. This patch fixes the issue by compiling the file on all
> operating systems. It also sorts the file names in meson.build in
> alphabetical order.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Best regards,
Dariusz Sosnowski
next prev parent reply other threads:[~2025-06-03 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 14:45 [PATCH 0/1] " Andre Muezerie
2025-05-05 14:45 ` [PATCH 1/1] net/mlx5: " Andre Muezerie
2025-06-03 14:57 ` Dariusz Sosnowski [this message]
2025-06-04 15:00 ` Raslan Darawsheh
2025-06-03 1:05 ` [PATCH 0/1] " Andre Muezerie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250603145709.wtlv3stxqbblduoa@ds-vm-debian.local \
--to=dsosnowski@nvidia.com \
--cc=andremue@linux.microsoft.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).