* [PATCH 0/1] unresolved symbol mlx5_geneve_tlv_parser_create
@ 2025-05-05 14:45 Andre Muezerie
2025-05-05 14:45 ` [PATCH 1/1] net/mlx5: " Andre Muezerie
2025-06-03 1:05 ` [PATCH 0/1] " Andre Muezerie
0 siblings, 2 replies; 5+ messages in thread
From: Andre Muezerie @ 2025-05-05 14:45 UTC (permalink / raw)
Cc: dev, Andre Muezerie
When compiling DPDK with mlx5 using clang on Windows with
"debug" buildtype the error below is hit:
net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol
mlx5_geneve_tlv_parser_create referenced in function
flow_dv_discover_priorities
drivers\rte_net_mlx5-25.dll : fatal error LNK1120: 1 unresolved externals
With a "release" buildtype the error is not seen, which explains why this
issue was not reported earlier.
The same problem will show up with MSVC, but patches which are still under
review are needed for this to be hit with MSVC.
The cause of this problem seems to be that mlx5_flow_geneve.c is only
compiled on Linux. This patch fixes the issue by compiling the file on all
operating systems. It also sorts the file names in meson.build in
alphabetical order.
REPRO STEPS (On Windows)
set DEVX_INC_PATH=V:\soft\MLNX_WinOF2_DevX_SDK\inc
set DEVX_LIB_PATH=V:\soft\MLNX_WinOF2_DevX_SDK\lib
set CFLAGS=-I"%DEVX_INC_PATH%"
set LDFLAGS=-Wl,-LIBPATH:"%DEVX_LIB_PATH%"
set CC=clang
meson setup -Dexamples=helloworld build --buildtype debug
ninja -C build
Andre Muezerie (1):
net/mlx5: unresolved symbol mlx5_geneve_tlv_parser_create
drivers/net/mlx5/meson.build | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--
2.49.0.vfs.0.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] net/mlx5: unresolved symbol mlx5_geneve_tlv_parser_create
2025-05-05 14:45 [PATCH 0/1] unresolved symbol mlx5_geneve_tlv_parser_create Andre Muezerie
@ 2025-05-05 14:45 ` Andre Muezerie
2025-06-03 14:57 ` Dariusz Sosnowski
2025-06-04 15:00 ` Raslan Darawsheh
2025-06-03 1:05 ` [PATCH 0/1] " Andre Muezerie
1 sibling, 2 replies; 5+ messages in thread
From: Andre Muezerie @ 2025-05-05 14:45 UTC (permalink / raw)
To: Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao, Ori Kam,
Suanming Mou, Matan Azrad
Cc: dev, Andre Muezerie
When compiling DPDK with mlx5 using clang on Windows with
"debug" buildtype the error below is hit:
net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol
mlx5_geneve_tlv_parser_create referenced in function
flow_dv_discover_priorities
drivers\rte_net_mlx5-25.dll : fatal error LNK1120: 1 unresolved externals
With a "release" buildtype the error is not seen, which explains why this
issue was not reported earlier.
The same problem will show up with MSVC, but patches which are still under
review are needed for this to be hit with MSVC.
The cause of this problem seems to be that mlx5_flow_geneve.c is only
compiled on Linux. This patch fixes the issue by compiling the file on all
operating systems. It also sorts the file names in meson.build in
alphabetical order.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
drivers/net/mlx5/meson.build | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index 78a8648b43..6a91692759 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -17,41 +17,41 @@ endif
headers = files('rte_pmd_mlx5.h')
sources = files(
'mlx5.c',
+ 'mlx5_devx.c',
'mlx5_ethdev.c',
'mlx5_flow.c',
- 'mlx5_flow_meter.c',
- 'mlx5_flow_dv.c',
'mlx5_flow_aso.c',
+ 'mlx5_flow_dv.c',
'mlx5_flow_flex.c',
+ 'mlx5_flow_geneve.c',
+ 'mlx5_flow_meter.c',
'mlx5_mac.c',
+ 'mlx5_nta_rss.c',
'mlx5_rss.c',
'mlx5_rx.c',
'mlx5_rxmode.c',
'mlx5_rxq.c',
'mlx5_rxtx.c',
'mlx5_stats.c',
- 'mlx5_trigger.c',
'mlx5_trace.c',
+ 'mlx5_trigger.c',
'mlx5_tx.c',
'mlx5_tx_empw.c',
'mlx5_tx_mpw.c',
'mlx5_tx_nompw.c',
'mlx5_tx_txpp.c',
- 'mlx5_txq.c',
'mlx5_txpp.c',
- 'mlx5_vlan.c',
+ 'mlx5_txq.c',
'mlx5_utils.c',
- 'mlx5_devx.c',
- 'mlx5_nta_rss.c',
+ 'mlx5_vlan.c',
)
if is_linux
sources += files(
- 'mlx5_flow_geneve.c',
'mlx5_flow_hw.c',
- 'mlx5_hws_cnt.c',
'mlx5_flow_quota.c',
'mlx5_flow_verbs.c',
+ 'mlx5_hws_cnt.c',
'mlx5_nta_split.c',
)
endif
--
2.49.0.vfs.0.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/1] unresolved symbol mlx5_geneve_tlv_parser_create
2025-05-05 14:45 [PATCH 0/1] unresolved symbol mlx5_geneve_tlv_parser_create Andre Muezerie
2025-05-05 14:45 ` [PATCH 1/1] net/mlx5: " Andre Muezerie
@ 2025-06-03 1:05 ` Andre Muezerie
1 sibling, 0 replies; 5+ messages in thread
From: Andre Muezerie @ 2025-06-03 1:05 UTC (permalink / raw)
To: dev
On Mon, May 05, 2025 at 07:45:36AM -0700, Andre Muezerie wrote:
> When compiling DPDK with mlx5 using clang on Windows with
> "debug" buildtype the error below is hit:
>
> net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol
> mlx5_geneve_tlv_parser_create referenced in function
> flow_dv_discover_priorities
> drivers\rte_net_mlx5-25.dll : fatal error LNK1120: 1 unresolved externals
>
> With a "release" buildtype the error is not seen, which explains why this
> issue was not reported earlier.
>
> The same problem will show up with MSVC, but patches which are still under
> review are needed for this to be hit with MSVC.
>
> The cause of this problem seems to be that mlx5_flow_geneve.c is only
> compiled on Linux. This patch fixes the issue by compiling the file on all
> operating systems. It also sorts the file names in meson.build in
> alphabetical order.
>
>
> REPRO STEPS (On Windows)
>
> set DEVX_INC_PATH=V:\soft\MLNX_WinOF2_DevX_SDK\inc
> set DEVX_LIB_PATH=V:\soft\MLNX_WinOF2_DevX_SDK\lib
> set CFLAGS=-I"%DEVX_INC_PATH%"
> set LDFLAGS=-Wl,-LIBPATH:"%DEVX_LIB_PATH%"
> set CC=clang
> meson setup -Dexamples=helloworld build --buildtype debug
> ninja -C build
>
>
> Andre Muezerie (1):
> net/mlx5: unresolved symbol mlx5_geneve_tlv_parser_create
>
> drivers/net/mlx5/meson.build | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> --
> 2.49.0.vfs.0.0
Would someone be able to review this patchset?
Thanks,
Andre Muezerie
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] net/mlx5: unresolved symbol mlx5_geneve_tlv_parser_create
2025-05-05 14:45 ` [PATCH 1/1] net/mlx5: " Andre Muezerie
@ 2025-06-03 14:57 ` Dariusz Sosnowski
2025-06-04 15:00 ` Raslan Darawsheh
1 sibling, 0 replies; 5+ messages in thread
From: Dariusz Sosnowski @ 2025-06-03 14:57 UTC (permalink / raw)
To: Andre Muezerie
Cc: Viacheslav Ovsiienko, Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad, dev
Hi,
On Mon, May 05, 2025 at 07:45:37AM -0700, Andre Muezerie wrote:
> When compiling DPDK with mlx5 using clang on Windows with
> "debug" buildtype the error below is hit:
>
> net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol
> mlx5_geneve_tlv_parser_create referenced in function
> flow_dv_discover_priorities
> drivers\rte_net_mlx5-25.dll : fatal error LNK1120: 1 unresolved externals
>
> With a "release" buildtype the error is not seen, which explains why this
> issue was not reported earlier.
>
> The same problem will show up with MSVC, but patches which are still under
> review are needed for this to be hit with MSVC.
>
> The cause of this problem seems to be that mlx5_flow_geneve.c is only
> compiled on Linux. This patch fixes the issue by compiling the file on all
> operating systems. It also sorts the file names in meson.build in
> alphabetical order.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Best regards,
Dariusz Sosnowski
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] net/mlx5: unresolved symbol mlx5_geneve_tlv_parser_create
2025-05-05 14:45 ` [PATCH 1/1] net/mlx5: " Andre Muezerie
2025-06-03 14:57 ` Dariusz Sosnowski
@ 2025-06-04 15:00 ` Raslan Darawsheh
1 sibling, 0 replies; 5+ messages in thread
From: Raslan Darawsheh @ 2025-06-04 15:00 UTC (permalink / raw)
To: Andre Muezerie, Dariusz Sosnowski, Viacheslav Ovsiienko,
Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad
Cc: dev
Hi,
On 05/05/2025 5:45 PM, Andre Muezerie wrote:
> When compiling DPDK with mlx5 using clang on Windows with
> "debug" buildtype the error below is hit:
>
> net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol
> mlx5_geneve_tlv_parser_create referenced in function
> flow_dv_discover_priorities
> drivers\rte_net_mlx5-25.dll : fatal error LNK1120: 1 unresolved externals
>
> With a "release" buildtype the error is not seen, which explains why this
> issue was not reported earlier.
>
> The same problem will show up with MSVC, but patches which are still under
> review are needed for this to be hit with MSVC.
>
> The cause of this problem seems to be that mlx5_flow_geneve.c is only
> compiled on Linux. This patch fixes the issue by compiling the file on all
> operating systems. It also sorts the file names in meson.build in
> alphabetical order.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-04 15:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-05 14:45 [PATCH 0/1] unresolved symbol mlx5_geneve_tlv_parser_create Andre Muezerie
2025-05-05 14:45 ` [PATCH 1/1] net/mlx5: " Andre Muezerie
2025-06-03 14:57 ` Dariusz Sosnowski
2025-06-04 15:00 ` Raslan Darawsheh
2025-06-03 1:05 ` [PATCH 0/1] " Andre Muezerie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).