* [PATCH] net/mlx5: use portable version of __builtin_ffsl
@ 2025-05-05 15:04 Andre Muezerie
2025-06-03 1:10 ` Andre Muezerie
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andre Muezerie @ 2025-05-05 15:04 UTC (permalink / raw)
To: Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao, Ori Kam,
Suanming Mou, Matan Azrad
Cc: dev, Andre Muezerie
Builtin __builtin_ffsl is not available with MSVC therefore a
portable replacement should be used.
Function rte_ffs32 is already available in eal and should be used
instead.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
drivers/net/mlx5/mlx5_tx.c | 4 ++--
drivers/net/mlx5/mlx5_utils.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c
index 39afca3d64..b2522e7170 100644
--- a/drivers/net/mlx5/mlx5_tx.c
+++ b/drivers/net/mlx5/mlx5_tx.c
@@ -629,8 +629,8 @@ mlx5_select_tx_function(struct rte_eth_dev *dev)
}
if (tmp == diff) {
tmp = txoff_func[i].olx ^ txoff_func[m].olx;
- if (__builtin_ffsl(txoff_func[i].olx & ~tmp) <
- __builtin_ffsl(txoff_func[m].olx & ~tmp)) {
+ if (rte_ffs32(txoff_func[i].olx & ~tmp) <
+ rte_ffs32(txoff_func[m].olx & ~tmp)) {
/* Lighter not requested offload. */
m = i;
}
diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c
index d882af6047..645bb118fb 100644
--- a/drivers/net/mlx5/mlx5_utils.c
+++ b/drivers/net/mlx5/mlx5_utils.c
@@ -84,7 +84,7 @@ mlx5_ipool_create(struct mlx5_indexed_pool_config *cfg)
if (!cfg || (!cfg->malloc ^ !cfg->free) ||
(cfg->per_core_cache && cfg->release_mem_en) ||
(cfg->trunk_size && ((cfg->trunk_size & (cfg->trunk_size - 1)) ||
- ((__builtin_ffs(cfg->trunk_size) + TRUNK_IDX_BITS) > 32))))
+ ((rte_ffs32(cfg->trunk_size) + TRUNK_IDX_BITS) > 32))))
return NULL;
pool = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*pool) + cfg->grow_trunk *
sizeof(pool->grow_tbl[0]), RTE_CACHE_LINE_SIZE,
--
2.49.0.vfs.0.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx5: use portable version of __builtin_ffsl
2025-05-05 15:04 [PATCH] net/mlx5: use portable version of __builtin_ffsl Andre Muezerie
@ 2025-06-03 1:10 ` Andre Muezerie
2025-06-03 15:23 ` Dariusz Sosnowski
2025-06-04 15:02 ` Raslan Darawsheh
2 siblings, 0 replies; 4+ messages in thread
From: Andre Muezerie @ 2025-06-03 1:10 UTC (permalink / raw)
To: Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao, Ori Kam,
Suanming Mou, Matan Azrad
Cc: dev
On Mon, May 05, 2025 at 08:04:52AM -0700, Andre Muezerie wrote:
> Builtin __builtin_ffsl is not available with MSVC therefore a
> portable replacement should be used.
>
> Function rte_ffs32 is already available in eal and should be used
> instead.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
> drivers/net/mlx5/mlx5_tx.c | 4 ++--
> drivers/net/mlx5/mlx5_utils.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c
> index 39afca3d64..b2522e7170 100644
> --- a/drivers/net/mlx5/mlx5_tx.c
> +++ b/drivers/net/mlx5/mlx5_tx.c
> @@ -629,8 +629,8 @@ mlx5_select_tx_function(struct rte_eth_dev *dev)
> }
> if (tmp == diff) {
> tmp = txoff_func[i].olx ^ txoff_func[m].olx;
> - if (__builtin_ffsl(txoff_func[i].olx & ~tmp) <
> - __builtin_ffsl(txoff_func[m].olx & ~tmp)) {
> + if (rte_ffs32(txoff_func[i].olx & ~tmp) <
> + rte_ffs32(txoff_func[m].olx & ~tmp)) {
> /* Lighter not requested offload. */
> m = i;
> }
> diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c
> index d882af6047..645bb118fb 100644
> --- a/drivers/net/mlx5/mlx5_utils.c
> +++ b/drivers/net/mlx5/mlx5_utils.c
> @@ -84,7 +84,7 @@ mlx5_ipool_create(struct mlx5_indexed_pool_config *cfg)
> if (!cfg || (!cfg->malloc ^ !cfg->free) ||
> (cfg->per_core_cache && cfg->release_mem_en) ||
> (cfg->trunk_size && ((cfg->trunk_size & (cfg->trunk_size - 1)) ||
> - ((__builtin_ffs(cfg->trunk_size) + TRUNK_IDX_BITS) > 32))))
> + ((rte_ffs32(cfg->trunk_size) + TRUNK_IDX_BITS) > 32))))
> return NULL;
> pool = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*pool) + cfg->grow_trunk *
> sizeof(pool->grow_tbl[0]), RTE_CACHE_LINE_SIZE,
> --
> 2.49.0.vfs.0.2
Would someone be able to review this patchset?
Thanks,
Andre Muezerie
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx5: use portable version of __builtin_ffsl
2025-05-05 15:04 [PATCH] net/mlx5: use portable version of __builtin_ffsl Andre Muezerie
2025-06-03 1:10 ` Andre Muezerie
@ 2025-06-03 15:23 ` Dariusz Sosnowski
2025-06-04 15:02 ` Raslan Darawsheh
2 siblings, 0 replies; 4+ messages in thread
From: Dariusz Sosnowski @ 2025-06-03 15:23 UTC (permalink / raw)
To: Andre Muezerie
Cc: Viacheslav Ovsiienko, Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad, dev
Hi,
On Mon, May 05, 2025 at 08:04:52AM -0700, Andre Muezerie wrote:
> Builtin __builtin_ffsl is not available with MSVC therefore a
> portable replacement should be used.
>
> Function rte_ffs32 is already available in eal and should be used
> instead.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Best regards,
Dariusz Sosnowski
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx5: use portable version of __builtin_ffsl
2025-05-05 15:04 [PATCH] net/mlx5: use portable version of __builtin_ffsl Andre Muezerie
2025-06-03 1:10 ` Andre Muezerie
2025-06-03 15:23 ` Dariusz Sosnowski
@ 2025-06-04 15:02 ` Raslan Darawsheh
2 siblings, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2025-06-04 15:02 UTC (permalink / raw)
To: Andre Muezerie, Dariusz Sosnowski, Viacheslav Ovsiienko,
Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad
Cc: dev
Hi,
On 05/05/2025 6:04 PM, Andre Muezerie wrote:
> Builtin __builtin_ffsl is not available with MSVC therefore a
> portable replacement should be used.
>
> Function rte_ffs32 is already available in eal and should be used
> instead.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-04 15:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-05 15:04 [PATCH] net/mlx5: use portable version of __builtin_ffsl Andre Muezerie
2025-06-03 1:10 ` Andre Muezerie
2025-06-03 15:23 ` Dariusz Sosnowski
2025-06-04 15:02 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).