From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Andre Muezerie <andremue@linux.microsoft.com>,
Patrick Robb <probb@iol.unh.edu>
Cc: Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>, <dev@dpdk.org>
Subject: Re: [PATCH] common/mlx5: avoid warning about operation mixing different enum types
Date: Wed, 4 Jun 2025 09:42:31 +0200 [thread overview]
Message-ID: <20250604074231.fc75n7ooaup75st6@ds-vm-debian.local> (raw)
In-Reply-To: <20250603164124.u7rrxwgwe2h5py2n@ds-vm-debian.local>
Hi,
On Tue, Jun 03, 2025 at 06:41:24PM +0200, Dariusz Sosnowski wrote:
> Hi,
>
> On Tue, May 27, 2025 at 04:41:25PM -0700, Andre Muezerie wrote:
> > When compiling with MSVC, warnings like the one below pop up:
> >
> > ../drivers/common/mlx5/mlx5_devx_cmds.c(554): warning C5287: operands
> > are different enum types
> > '<unnamed-enum-MLX5_GET_HCA_CAP_OP_MOD_GENERAL_DEVICE>' and
> > '<unnamed-enum-MLX5_HCA_CAP_OPMOD_GET_MAX>'; use an explicit cast
> > to silence this warning
> >
> > The values in both enums indicate that this sort of mixed bit
> > manipulation is intentional, so this patch just uses an explicit
> > cast to avoid the warning.
> >
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
>
> Best regards,
> Dariusz Sosnowski
@Patrick Could you please take a look at CI failures for this patch?
Here is the test report log: https://mails.dpdk.org/archives/test-report/2025-May/882321.html
There is a Fedora 41 compilation failure in "dpdk_compile_spdk".
It seems on the related to the patch, because it fails in SPDK code.
@Andre Could you please take a look at CI failure on Windows?
There is a unit tests failure on Windows Server 2022.
Best regards,
Dariusz Sosnowski
next prev parent reply other threads:[~2025-06-04 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 23:41 Andre Muezerie
2025-06-03 16:41 ` Dariusz Sosnowski
2025-06-04 7:42 ` Dariusz Sosnowski [this message]
2025-06-04 15:18 ` Andre Muezerie
2025-06-05 8:32 ` Dariusz Sosnowski
2025-06-04 15:02 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604074231.fc75n7ooaup75st6@ds-vm-debian.local \
--to=dsosnowski@nvidia.com \
--cc=andremue@linux.microsoft.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=probb@iol.unh.edu \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).