Re: [PATCH] common/mlx5: avoid warning about operation mixing different enum types

[Andre Muezerie <andremue@linux.microsoft.com>]

On Wed, Jun 04, 2025 at 09:42:31AM +0200, Dariusz Sosnowski wrote:
> Hi,
> 
> On Tue, Jun 03, 2025 at 06:41:24PM +0200, Dariusz Sosnowski wrote:
> > Hi,
> > 
> > On Tue, May 27, 2025 at 04:41:25PM -0700, Andre Muezerie wrote:
> > > When compiling with MSVC, warnings like the one below pop up:
> > > 
> > > ../drivers/common/mlx5/mlx5_devx_cmds.c(554): warning C5287: operands
> > >     are different enum types
> > >     '<unnamed-enum-MLX5_GET_HCA_CAP_OP_MOD_GENERAL_DEVICE>' and
> > >     '<unnamed-enum-MLX5_HCA_CAP_OPMOD_GET_MAX>'; use an explicit cast
> > >     to silence this warning
> > > 
> > > The values in both enums indicate that this sort of mixed bit
> > > manipulation is intentional, so this patch just uses an explicit
> > > cast to avoid the warning.
> > > 
> > > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > 
> > Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> > 
> > Best regards,
> > Dariusz Sosnowski
> 
> @Patrick Could you please take a look at CI failures for this patch?
> Here is the test report log: https://mails.dpdk.org/archives/test-report/2025-May/882321.html
> There is a Fedora 41 compilation failure in "dpdk_compile_spdk".
> It seems on the related to the patch, because it fails in SPDK code.
> 
> @Andre Could you please take a look at CI failure on Windows?
> There is a unit tests failure on Windows Server 2022.
> 

Hi Dariusz,

I looked at the failed test. It should be unrelated to this patch. I ran
the same lcores_autotest on my machine compiling with MSVC and Clang
and it passed (with the changes in the patch).

For completeness, here is the output from CI:

44/92 DPDK:fast-tests / lcore_var_autotest             OK               0.35s
meson : ERROR: The process "4692" not found.
At C:\Users\builder\jenkins\workspace\Generic-VM-Unit-Test-DPDK@tmp\durable-3a3a8aa3\powershellScript.ps1:3 char:45
+ ...                      meson test --suite fast-tests -t 60 2>&1 | tee - ...
+                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (ERROR: The process "4692" not found.:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
45/92 DPDK:fast-tests / lcores_autotest                TIMEOUT        629.35s
>>> DPDK_TEST=lcores_autotest MALLOC_PERTURB_=25 C:\Users\builder\jenkins\workspace\Generic-VM-Unit-Test-DPDK\dpdk\build\app\dpdk-test.exe --no-huge -m 2048

46/92 DPDK:fast-tests / logs_autotest                  OK               0.16s

Thanks,
Andre Muezerie

> Best regards,
> Dariusz Sosnowski