From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DB7A4687B; Wed, 4 Jun 2025 17:30:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3534942DF1; Wed, 4 Jun 2025 17:30:32 +0200 (CEST) Received: from mx0a-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D3A38402B1 for ; Wed, 4 Jun 2025 17:30:30 +0200 (CEST) Received: from pps.filterd (m0431384.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 553NVhvm018889; Wed, 4 Jun 2025 08:30:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=N La0CaYO/DXDZx9xQtV0+bi5coe5NQf0VV7Ie7FuEqg=; b=AtS0CKNIUYycI9ZRm /t5Tko4SaUsbgb2uW4a1rW5RN+WJbSYH2CQHk8gnxp4GwJ2Pttw9nCKi/Ru3zZdl hq66aEMrjN8YViR5gQc8tQmRm8syQHhG64mIeaWSDOy7jL2R9y+1+sGsZvdepLh9 WKsvZTWatOdO0zk0z/5l6rDyxHvF7FZ7mVvYrtowUb5ADoqd9MRhNw73Jfvj4+Xs z+uG4Qen0/Wmvvz8K32Jr3a7Tl1Vn2vQw+sQckdOSyZDtob+Pv1fJhv8NT45W9eu uXmoKfFlKiDSFF/qhMZJFJooVAPeJEQq8H8FQVms4NUM7d5y+CnPtmm65zDTpijc hH/nA== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 472at51w1q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Jun 2025 08:30:25 -0700 (PDT) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 4 Jun 2025 08:30:24 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Wed, 4 Jun 2025 08:30:24 -0700 Received: from cavium-PowerEdge-R640.. (unknown [10.28.36.207]) by maili.marvell.com (Postfix) with ESMTP id E42CE3F704E; Wed, 4 Jun 2025 08:30:21 -0700 (PDT) From: Nitin Saxena To: Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Zhirun Yan , Robin Jarry , Christophe Fontaine CC: , Nitin Saxena Subject: [PATCH v11 0/7] add feature arc in rte_graph Date: Wed, 4 Jun 2025 21:00:01 +0530 Message-ID: <20250604153020.92712-1-nsaxena@marvell.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250103060612.2671836-1-nsaxena@marvell.com> References: <20250103060612.2671836-1-nsaxena@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: YBYq5-BtqRpYoAJyVBzeVlZ2koMZAgRM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA0MDExNyBTYWx0ZWRfX6wT1aXXHsXxs 9Kqic6Hgtstvx7T6F1RPRjogKHy+g+9ffJ8u1f7wFPxynw3ZK00tycunJ8W/C7ogeKhugqVWILd feQPjU1e715MXPus0hIdhBXvb2OhOmwKo7pb0bWQFz1ZRzB5hx09Pz4Yz8LuGcwtjBQ0SMQfphg n0ANFO1u2iOtscEq9Jrb20cffapTjr4+e7cBSVIdZdVO8122gGCsBclVXjUWO/DCtC59QzhbztF UF+9E4OWf1WoNpoTmUEQyUhDFKt/Tw9nY1TSVUu+kdtECHCSOLJsUJcRR9LeYvTuhWF4i6saTZC 9BsRd+v4eXArqJO9nlycrIW0UBMMx003l19R9aSH+HUn5lyvIEA1KO1h2fkVEsap9atsfto+hAp WUu/VPbCFbv7SrZw6uEHv76/HlaNauG/BB3SIt0yo0w9rddR70eGwEBxRZlXbbkS+/LJuX0c X-Authority-Analysis: v=2.4 cv=F9dXdrhN c=1 sm=1 tr=0 ts=68406691 cx=c_pps a=rEv8fa4AjpPjGxpoe8rlIQ==:117 a=rEv8fa4AjpPjGxpoe8rlIQ==:17 a=6IFa9wvqVegA:10 a=NEAV23lmAAAA:8 a=VDk4JRl-7iTCIaFRHVcA:9 X-Proofpoint-GUID: YBYq5-BtqRpYoAJyVBzeVlZ2koMZAgRM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-04_03,2025-06-03_02,2025-03-28_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Feature arc represents an ordered list of features/protocols at a given networking layer. It is a high level abstraction to express relationship between rte_graph nodes, as feature nodes, and allow packets steering across these nodes in a simplified manner. Features (or feature nodes) are nodes which handles partial or complete handling of a protocol in fast path. Like ipv4-rewrite node, which adds rewrite data to an outgoing IPv4 packet. However in above example, outgoing interface(say "eth0") may have outbound IPsec policy enabled, hence packets must be steered from ipv4-rewrite node to outbound-IPsec-policy node. On the other hand, packets routed to another interface (say eth1) must ot be sent to IPsec node, as IPsec feature is disabled on eth1. Feature-arc allows rte_graph applications to manage such constraints easily Feature arc abstraction allows rte_graph based application to 1. Runtime enable/disable features on an index (like interface), so that if a feature is enabled at runtime, only then packets associated with that interface will steer to corresponding feature node. Control plane enables/disables features. Features enabled on one interface may not be enabled on another interface with in a same feature arc. 2. Single feature arc represents a hook point at a network layer in an given direction. Multiple feature arcs can be added in desginated nodes to add various hook points in stack. Likt IPv4-output, IPv4-input, IPv6-output, IPv6-input, ethernet-input, mpls-input, mpls-output etc. 3. Hook custom/out-of-tree nodes to DPDK in-built nodes and allow packet steering from in-built node to custom node without requiring changes to in-built fast path function 4. Express features in a particular sequential order so that packets are steered in an ordered way across nodes in fast path. For eg: if IPsec and IPv4 features are enabled on an ingress interface, packets must be sent to IPsec inbound policy node first and then to ipv4 lookup node. This patch series adds feature arc library in rte_graph and also adds "ipv4-output" feature arc handling in "ipv4-rewrite" node. Changes in v11 - Incorporated all comments from Kiran Changes in v10 - Incorporated all comments from Jerin - Splitted feature arc spec patch into 3 patches - added programming guide in each patch - Fixed documentation comments Changes in v9: - Fix build failures Changes in v8: - Fix CI iol testing Changes in v7: - Rebased to latest main for DPDK-25.07 - Added override_index_cb() in RTE_GRAPH_FEATURE_REGISTER() to allow features to take control of "max_index" (passed to rte_graph_feature_arc_create()) - Streamlined fast path APIs to make them more simpler - Added quad_loop in "if_tx_feature" node - Added functional test cases and fixed bugs - Based on feedback from Redhat on v6 patches, it was tried to move feature arc APIs inside rte_graph library (to reduce node burden) but it was adding 4% performance regression for L3fwd usecase. For interested users: https://github.com/nsaxena16/dpdk/pull/2 Changes in v6: - Rebased to latest main for DPDK-25.03 - Added constructor based feature arc/feature registration - Changed design to handle fast path synchronization via RCU mechanism when any feature is enabled or disabled - Added feature arc specific mbuf dynamic field to carry feature data across nodes - Added feature arc example in app/graph - Programming guide and functional test cases in future versions Nitin Saxena (7): graph: add API to override node process function graph: add feature arc registrations graph: add feature arc init APIs graph: add feature enable/disable APIs ip4: add ip4 output feature arc app/graph: add custom feature nodes for ip4 output arc test/graph_feature_arc: add functional tests app/graph/commands.list | 6 + app/graph/feature.c | 141 ++ app/graph/feature.h | 13 + app/graph/graph.c | 4 + app/graph/ip4_output_hook.c | 180 ++ app/graph/main.c | 15 +- app/graph/meson.build | 2 + app/graph/module_api.h | 2 + app/test/meson.build | 1 + app/test/test_graph_feature_arc.c | 1374 +++++++++++++ doc/api/doxy-api-index.md | 2 + doc/guides/prog_guide/graph_lib.rst | 490 +++++ doc/guides/prog_guide/img/feature_arc-1.svg | 269 +++ doc/guides/prog_guide/img/feature_arc-2.svg | 511 +++++ doc/guides/rel_notes/release_25_07.rst | 9 + doc/guides/tools/graph.rst | 15 + lib/graph/graph_feature_arc.c | 2058 +++++++++++++++++++ lib/graph/graph_private.h | 15 + lib/graph/meson.build | 4 +- lib/graph/node.c | 22 + lib/graph/rte_graph_feature_arc.h | 644 ++++++ lib/graph/rte_graph_feature_arc_worker.h | 603 ++++++ lib/node/ethdev_ctrl.c | 8 + lib/node/interface_tx_feature.c | 213 ++ lib/node/interface_tx_feature_priv.h | 33 + lib/node/ip4_rewrite.c | 286 ++- lib/node/meson.build | 1 + lib/node/node_private.h | 1 + lib/node/rte_node_ip4_api.h | 4 + 29 files changed, 6917 insertions(+), 9 deletions(-) create mode 100644 app/graph/feature.c create mode 100644 app/graph/feature.h create mode 100644 app/graph/ip4_output_hook.c create mode 100644 app/test/test_graph_feature_arc.c create mode 100644 doc/guides/prog_guide/img/feature_arc-1.svg create mode 100644 doc/guides/prog_guide/img/feature_arc-2.svg create mode 100644 lib/graph/graph_feature_arc.c create mode 100644 lib/graph/rte_graph_feature_arc.h create mode 100644 lib/graph/rte_graph_feature_arc_worker.h create mode 100644 lib/node/interface_tx_feature.c create mode 100644 lib/node/interface_tx_feature_priv.h -- 2.43.0