From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: <bingz@nvidia.com>, <dev@dpdk.org>, <matan@nvidia.com>,
<orika@nvidia.com>, <suanmingm@nvidia.com>,
<viacheslavo@nvidia.com>
Subject: Re: [PATCH v2] common/mlx5: use intrinsics instead of inline assembly
Date: Thu, 5 Jun 2025 10:35:27 +0200 [thread overview]
Message-ID: <20250605083527.ltovebzh7ispeksr@ds-vm-debian.local> (raw)
In-Reply-To: <20250605083354.em4pes3yfg3nta7h@ds-vm-debian.local>
On Thu, Jun 05, 2025 at 10:33:54AM +0200, Dariusz Sosnowski wrote:
> Hi,
>
> On Wed, Jun 04, 2025 at 07:15:25AM -0700, Andre Muezerie wrote:
> > When compiling with MSVC the errors below are hit because msvc does not
> > support inline assembly:
> >
> > 1)
> > ../drivers/common/mlx5/mlx5_common.c(86): warning C4013: '__asm__'
> > undefined; assuming extern returning int
> > ../drivers/common/mlx5/mlx5_common.c(87): error C2143: syntax error:
> > missing ')' before ':'
> >
> > 2)
> > ../drivers/net/mlx5/mlx5_txpp.c(510): error C2065: '__asm__':
> > undeclared identifier
> > ../drivers/net/mlx5/mlx5_txpp.c(510): error C2143: syntax error:
> > missing ';' before 'volatile'
> >
> > The fix for (1) is to use compiler intrinsic __cpuid and for (2)
> > intrinsic _InterlockedCompareExchange128 can be used.
> >
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
>
> Thank you for applying the changes.
>
> Best regards,
> Dariusz Sosnowski
Forgot about:
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
prev parent reply other threads:[~2025-06-05 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 14:57 [PATCH] " Andre Muezerie
2025-06-03 1:07 ` Andre Muezerie
2025-06-03 15:13 ` Dariusz Sosnowski
2025-06-04 14:17 ` Andre Muezerie
2025-06-04 14:15 ` [PATCH v2] " Andre Muezerie
2025-06-05 8:33 ` Dariusz Sosnowski
2025-06-05 8:35 ` Dariusz Sosnowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605083527.ltovebzh7ispeksr@ds-vm-debian.local \
--to=dsosnowski@nvidia.com \
--cc=andremue@linux.microsoft.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).