From: Stephen Hemminger <stephen@networkplumber.org>
To: Schneide <schneide@qti.qualcomm.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Reshma Pattan <reshma.pattan@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Zhirun Yan <yanzhirun_163@163.com>
Subject: Re: [PATCH v2] pcapng: allow any protocol link type for the interface block
Date: Sun, 8 Jun 2025 15:23:03 -0700 [thread overview]
Message-ID: <20250608152303.7fa38b15@hermes.local> (raw)
In-Reply-To: <20250606215208.389096-1-schneide@qti.qualcomm.com>
On Fri, 6 Jun 2025 15:52:08 -0600
Schneide <schneide@qti.qualcomm.com> wrote:
> From: Dylan Schneider <schneide@qti.qualcomm.com>
>
> Allow the user to specify protocol link type when creating pcapng files.
> This change is needed to specify the protocol type in the pcapng file,
> DLT_EN10MB specifies ethernet packets only. This will allow dissectors
> for other protocols to be used on files generated by pcapng.
>
> Includes a breaking change to rte_pcapng_add_interface to add link_type
> parameter. Existing calls to the function have been updated to pass
> DLT_EN10MB for the link type argument.
>
> Fixes: d1da6d0d04c7 ("pcapng: require per-interface information")
> Signed-off-by: Dylan Schneider <schneide@qti.qualcomm.com>
> Cc: stephen@networkplumber.org
$ ninja -C build doc
ninja: Entering directory `build'
[5/6] Generating doc/guides/html_guides with a custom command
release_25_07.rst:141: WARNING: Explicit markup ends without a blank line; unexpected unindent. [docutils]
next prev parent reply other threads:[~2025-06-08 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 17:16 [PATCH] " Schneide
2025-05-29 19:31 ` Stephen Hemminger
2025-05-29 19:57 ` Stephen Hemminger
2025-06-05 23:02 ` [PATCH v2] " Schneide
2025-06-06 15:13 ` Stephen Hemminger
2025-06-06 21:52 ` Schneide
2025-06-08 22:16 ` Stephen Hemminger
2025-06-08 22:19 ` Stephen Hemminger
2025-06-08 22:23 ` Stephen Hemminger [this message]
2025-06-08 22:30 ` Stephen Hemminger
2025-06-08 22:34 ` Stephen Hemminger
2025-06-09 15:51 ` Dylan Schneider
2025-06-09 16:24 ` Stephen Hemminger
2025-06-09 21:19 ` Schneide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250608152303.7fa38b15@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=reshma.pattan@intel.com \
--cc=schneide@qti.qualcomm.com \
--cc=thomas@monjalon.net \
--cc=yanzhirun_163@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).