[PATCH 1/2] ci: treat warning as error for MSVC builds in GHA

[PATCH 1/2] ci: treat warning as error for MSVC builds in GHA

[David Marchand]

Some trivial builds warnings with MSVC were missed as those were not
treated as errors.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1e289979e3..e5f17ef6ac 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -198,7 +198,7 @@ jobs:
       shell: cmd
       run: |
         call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
-        meson setup -Denable_stdatomic=true build
+        meson setup -Denable_stdatomic=true -Dwerror=true build
     - name: Build
       shell: cmd
       run: |
-- 
2.49.0

[PATCH 2/2] test/lcore: fix build with MSVC

[David Marchand]

MSVC warns about atomic qualifier:
../app/test/test_per_lcore.c(101): error C2220: the following warning is
	treated as an error
../app/test/test_per_lcore.c(101): warning C4090: 'function': different
	'_Atomic' qualifiers

Fixes: 7c37826c2b87 ("test/lcore: fix race in per-lcore test")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test/test_per_lcore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_per_lcore.c b/app/test/test_per_lcore.c
index 9c72f0fa21..e0674b0e70 100644
--- a/app/test/test_per_lcore.c
+++ b/app/test/test_per_lcore.c
@@ -98,7 +98,7 @@ test_per_lcore(void)
 	}
 
 	/* test if it could do remote launch twice at the same time or not */
-	ret = rte_eal_mp_remote_launch(test_per_lcore_delay, &wait, SKIP_MAIN);
+	ret = rte_eal_mp_remote_launch(test_per_lcore_delay, RTE_PTR_UNQUAL(&wait), SKIP_MAIN);
 	if (ret < 0) {
 		printf("It fails to do remote launch but it should able to do\n");
 		return -1;
-- 
2.49.0

Re: [PATCH 2/2] test/lcore: fix build with MSVC

[David Marchand]

On Tue, Jun 10, 2025 at 10:37 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> MSVC warns about atomic qualifier:
> ../app/test/test_per_lcore.c(101): error C2220: the following warning is
>         treated as an error
> ../app/test/test_per_lcore.c(101): warning C4090: 'function': different
>         '_Atomic' qualifiers
>
> Fixes: 7c37826c2b87 ("test/lcore: fix race in per-lcore test")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/test/test_per_lcore.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_per_lcore.c b/app/test/test_per_lcore.c
> index 9c72f0fa21..e0674b0e70 100644
> --- a/app/test/test_per_lcore.c
> +++ b/app/test/test_per_lcore.c
> @@ -98,7 +98,7 @@ test_per_lcore(void)
>         }
>
>         /* test if it could do remote launch twice at the same time or not */
> -       ret = rte_eal_mp_remote_launch(test_per_lcore_delay, &wait, SKIP_MAIN);
> +       ret = rte_eal_mp_remote_launch(test_per_lcore_delay, RTE_PTR_UNQUAL(&wait), SKIP_MAIN);
>         if (ret < 0) {
>                 printf("It fails to do remote launch but it should able to do\n");
>                 return -1;

Series applied.


-- 
David Marchand