Re: [PATCH v1 02/17] net/nbl: add simple probe/remove and log module

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 12 Jun 2025 08:58:23 +0000
Kyo Liu <kyo.liu@nebula-matrix.com> wrote:

> diff --git a/drivers/net/nbl/nbl_include/nbl_include.h b/drivers/net/nbl/nbl_include/nbl_include.h
> new file mode 100644
> index 0000000000..1697f50a75
> --- /dev/null
> +++ b/drivers/net/nbl/nbl_include/nbl_include.h
> @@ -0,0 +1,53 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright 2025 Nebulamatrix Technology Co., Ltd.
> + */
> +
> +#ifndef _NBL_INCLUDE_H_
> +#define _NBL_INCLUDE_H_
> +
> +#include <ctype.h>
> +#include <dirent.h>
> +#include <errno.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <limits.h>
> +#include <linux/netlink.h>
> +#include <linux/rtnetlink.h>
> +#include <linux/genetlink.h>
> +#include <linux/ethtool.h>
> +#include <netinet/in.h>
> +#include <net/if.h>
> +#include <net/if_arp.h>
> +#include <pthread.h>

DPDK locks and thread are preferred over direct access
to pthread.

> +#include <signal.h>

Not used, do not include

> +#include <stdarg.h>
> +#include <stdbool.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <sys/eventfd.h>

Direct use of eventfd is non-portable and should be avoided
in drivers.

> +#include <sys/ioctl.h>
> +#include <sys/mman.h>
> +#include <sys/queue.h>
> +#include <sys/stat.h>

Driver does not use this header?

> +#include <sys/types.h>
> +#include <unistd.h>
> +
> +#include <rte_ethdev.h>
> +#include <ethdev_driver.h>
> +#include <ethdev_pci.h>
> +#include <bus_pci_driver.h>
> +
> +#include "nbl_logs.h"
> +
> +typedef uint64_t u64;
> +typedef uint32_t u32;
> +typedef uint16_t u16;
> +typedef uint8_t u8;
> +typedef int64_t s64;
> +typedef int32_t s32;
> +typedef int16_t s16;
> +typedef int8_t s8;
> +
> +#endif