DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jiawen Wu <jiawenwu@trustnetic.com>
To: dev@dpdk.org
Cc: zaiyuwang@trustnetic.com, Jiawen Wu <jiawenwu@trustnetic.com>,
	stable@dpdk.org
Subject: [PATCH v3 05/17] net/txgbe: fix to create FDIR filters for SCTP packets
Date: Fri, 13 Jun 2025 16:41:47 +0800	[thread overview]
Message-ID: <20250613084159.22184-6-jiawenwu@trustnetic.com> (raw)
In-Reply-To: <20250613084159.22184-1-jiawenwu@trustnetic.com>

The check for the mask of SCTP item is repeated and wrong, fix it to
make it work.

Fixes: b973ee26747a ("net/txgbe: parse flow director filter")
Cc: stable@dpdk.org

Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
 drivers/net/txgbe/txgbe_flow.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c
index bce88aebd3..c7cbf96a46 100644
--- a/drivers/net/txgbe/txgbe_flow.c
+++ b/drivers/net/txgbe/txgbe_flow.c
@@ -2067,19 +2067,6 @@ txgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev __rte_unused,
 			rule->input.dst_port =
 				sctp_spec->hdr.dst_port;
 		}
-		/* others even sctp port is not supported */
-		sctp_mask = item->mask;
-		if (sctp_mask &&
-			(sctp_mask->hdr.src_port ||
-			 sctp_mask->hdr.dst_port ||
-			 sctp_mask->hdr.tag ||
-			 sctp_mask->hdr.cksum)) {
-			memset(rule, 0, sizeof(struct txgbe_fdir_rule));
-			rte_flow_error_set(error, EINVAL,
-				RTE_FLOW_ERROR_TYPE_ITEM,
-				item, "Not supported by fdir filter");
-			return -rte_errno;
-		}
 
 		item = next_no_fuzzy_pattern(pattern, item);
 		if (item->type != RTE_FLOW_ITEM_TYPE_RAW &&
-- 
2.48.1


  parent reply	other threads:[~2025-06-13  8:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06  8:01 [PATCH 00/12] Fixes and supports for Wangxun NICs Jiawen Wu
2025-06-09  7:04 ` [PATCH v2 " Jiawen Wu
     [not found] ` <20250609070454.223387-1-jiawenwu@trustnetic.com>
2025-06-09  7:04   ` [PATCH v2 01/12] net/txgbe: support flow filter for VF Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 02/12] net/txgbe: refactor FDIR filter to improve functionality Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 03/12] net/txgbe: fix reserved extra FDIR headroom Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 04/12] net/txgbe: support RSS offload for SCTP port Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 05/12] net/ngbe: " Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 06/12] net/txgbe: fix MAC control frame forwarding Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 07/12] net/ngbe: " Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 08/12] net/txgbe: fix incorrect device statistics Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 09/12] net/ngbe: " Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 10/12] net/txgbe: restrict VLAN strip configuration on VF Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 11/12] net/ngbe: " Jiawen Wu
2025-06-09  7:04   ` [PATCH v2 12/12] net/txgbe: add missing LRO flag in mbuf when LRO enabled Jiawen Wu
2025-06-10 23:38 ` [PATCH 00/12] Fixes and supports for Wangxun NICs Stephen Hemminger
2025-06-11  2:00 ` Stephen Hemminger
2025-06-13  8:41 ` [PATCH v3 00/17] " Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 01/17] net/txgbe: support flow filter for VF Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 02/17] net/txgbe: fix incorrect parsing to ntuple filter Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 03/17] net/txgbe: fix raw pattern match for FDIR rules Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 04/17] net/txgbe: fix packet type for FDIR filters Jiawen Wu
2025-06-13  8:41   ` Jiawen Wu [this message]
2025-06-13  8:41   ` [PATCH v3 06/17] net/txgbe: fix FDIR perfect mode for IPv6 packets Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 07/17] net/txgbe: fix to create FDIR filters for tunnel packets Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 08/17] net/txgbe: fix reserved extra FDIR headroom Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 09/17] net/txgbe: support RSS offload for SCTP port Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 10/17] net/ngbe: " Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 11/17] net/txgbe: fix MAC control frame forwarding Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 12/17] net/ngbe: " Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 13/17] net/txgbe: fix incorrect device statistics Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 14/17] net/ngbe: " Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 15/17] net/txgbe: restrict VLAN strip configuration on VF Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 16/17] net/ngbe: " Jiawen Wu
2025-06-13  8:41   ` [PATCH v3 17/17] net/txgbe: add missing LRO flag in mbuf when LRO enabled Jiawen Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250613084159.22184-6-jiawenwu@trustnetic.com \
    --to=jiawenwu@trustnetic.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=zaiyuwang@trustnetic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).