From: Tomasz Duszynski <tduszynski@marvell.com>
To: <thomas@monjalon.net>
Cc: <bruce.richardson@intel.com>, <david.marchand@redhat.com>,
<dev@dpdk.org>, <jerinj@marvell.com>,
<roretzla@linux.microsoft.com>, <skori@marvell.com>,
<tduszynski@marvell.com>
Subject: Re: [PATCH 6/6] trace: add PMU
Date: Mon, 16 Jun 2025 11:49:03 +0200 [thread overview]
Message-ID: <20250616094903.3236231-1-tduszynski@marvell.com> (raw)
In-Reply-To: <21436140.jiFIW2sfyF@thomas>
>16/06/2025 08:53, Tomasz Duszynski:
>> @@ -86,6 +86,7 @@ always_enable = [
>> 'ring',
>> 'stack',
>> 'telemetry',
>> + 'pmu',
>> ]
>
>This list is alphabetically sorted.
Right, missed that.
>
>What is the justification for always enabling PMU lib?
>Is it a good idea to always enable an experimental library?
Well, since on Linux eal depends on pmu, disabling pmu ends up disabling
eal, which breaks minimal build.
As for the second question - no. I think ideally lib should remain
optional. However, since trace is part of eal, that indirectly forces
pmu to be built.
Alternatively, I guess we could make the library explicitly optional by
extra meson option. But given that there are already options for
controlling libraries that approach is not perfect either.
next prev parent reply other threads:[~2025-06-16 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 6:53 [PATCH 0/6] lib/pmu: cleanups and trace integration Tomasz Duszynski
2025-06-16 6:53 ` [PATCH 1/6] lib/pmu: quiesce rte_pmu_read deprecation warning in chkincs Tomasz Duszynski
2025-06-16 6:53 ` [PATCH 2/6] lib/pmu: export only necessary arch headers Tomasz Duszynski
2025-06-16 6:53 ` [PATCH 3/6] lib/pmu: reimplement per-arch ops as callbacks Tomasz Duszynski
2025-06-16 7:03 ` Thomas Monjalon
2025-06-16 9:54 ` Tomasz Duszynski
2025-06-16 6:53 ` [PATCH 4/6] lib/pmu: use build system defined RTE_LIB_PMU macro Tomasz Duszynski
2025-06-16 7:08 ` Thomas Monjalon
2025-06-16 10:53 ` Tomasz Duszynski
2025-06-16 6:53 ` [PATCH 5/6] test/pmu: enable fast test Tomasz Duszynski
2025-06-16 6:53 ` [PATCH 6/6] trace: add PMU Tomasz Duszynski
2025-06-16 7:13 ` Thomas Monjalon
2025-06-16 9:49 ` Tomasz Duszynski [this message]
2025-06-16 10:32 ` Bruce Richardson
2025-06-16 13:18 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616094903.3236231-1-tduszynski@marvell.com \
--to=tduszynski@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=roretzla@linux.microsoft.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).