From: Dean Marx <dmarx@iol.unh.edu>
To: probb@iol.unh.edu, luca.vizzarro@arm.com,
yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
paul.szczepanek@arm.com
Cc: dev@dpdk.org, Dean Marx <dmarx@iol.unh.edu>
Subject: [PATCH v2] dts: fix devbind initialization bug
Date: Mon, 16 Jun 2025 14:35:27 -0400 [thread overview]
Message-ID: <20250616183527.645888-1-dmarx@iol.unh.edu> (raw)
In-Reply-To: <20250612201220.614724-1-dmarx@iol.unh.edu>
Rearrange the topology and DPDK setup/teardown calls during
test runs to ensure the devbind script is not called
while the DPDK tmp directory doesn't exist.
Fixes: 4cef16f1f0a4 ("dts: improve port handling")
Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
---
dts/framework/test_run.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/dts/framework/test_run.py b/dts/framework/test_run.py
index cff0085317..60a9ec8148 100644
--- a/dts/framework/test_run.py
+++ b/dts/framework/test_run.py
@@ -344,8 +344,9 @@ def next(self) -> State | None:
test_run.ctx.sut_node.setup()
test_run.ctx.tg_node.setup()
- test_run.ctx.topology.setup()
test_run.ctx.dpdk.setup()
+ test_run.ctx.topology.setup()
+ self.test_run.ctx.topology.configure_ports("sut", "dpdk")
test_run.ctx.tg.setup(test_run.ctx.topology)
self.result.ports = test_run.ctx.topology.sut_ports + test_run.ctx.topology.tg_ports
@@ -433,8 +434,8 @@ def next(self) -> State | None:
"""Next state."""
self.test_run.ctx.shell_pool.terminate_current_pool()
self.test_run.ctx.tg.teardown()
- self.test_run.ctx.dpdk.teardown()
self.test_run.ctx.topology.teardown()
+ self.test_run.ctx.dpdk.teardown()
self.test_run.ctx.tg_node.teardown()
self.test_run.ctx.sut_node.teardown()
self.result.update_teardown(Result.PASS)
--
2.49.0
next prev parent reply other threads:[~2025-06-16 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 20:12 [PATCH v1] " Dean Marx
2025-06-16 3:21 ` Patrick Robb
2025-06-16 18:35 ` Dean Marx [this message]
2025-06-16 18:38 ` [PATCH v2] " Dean Marx
2025-06-17 0:17 ` Patrick Robb
2025-06-17 0:51 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616183527.645888-1-dmarx@iol.unh.edu \
--to=dmarx@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).