Re: [PATCH v1 1/1] net/zxdh: add support flow director ops

Re: [PATCH v1 1/1] net/zxdh: add support flow director ops

[Stephen Hemminger]

On Tue, 17 Jun 2025 14:36:04 +0800
Bingbin Chen <chen.bingbin@zte.com.cn> wrote:

> Provide support for ETH, VLAN, IPv4/IPv6, TCP/UDP, VXLAN, and mask matching,
> supporting multiple actions include drop/count/mark/queue/rss,and vxlan decap/encap.
> 
> Signed-off-by: Bingbin Chen <chen.bingbin@zte.com.cn>
> ---
>  drivers/net/zxdh/meson.build       |    1 +
>  drivers/net/zxdh/zxdh_common.h     |    1 +
>  drivers/net/zxdh/zxdh_ethdev.c     |   27 +
>  drivers/net/zxdh/zxdh_ethdev.h     |   13 +-
>  drivers/net/zxdh/zxdh_ethdev_ops.c |    2 +-
>  drivers/net/zxdh/zxdh_ethdev_ops.h |    1 +
>  drivers/net/zxdh/zxdh_flow.c       | 2004 ++++++++++++++++++++++++++++
>  drivers/net/zxdh/zxdh_flow.h       |  237 ++++
>  drivers/net/zxdh/zxdh_msg.c        |  263 +++-
>  drivers/net/zxdh/zxdh_msg.h        |   31 +-
>  drivers/net/zxdh/zxdh_np.c         | 1664 +++++++++++++++++++++++
>  drivers/net/zxdh/zxdh_np.h         |   42 +-
>  drivers/net/zxdh/zxdh_tables.h     |   10 +-
>  13 files changed, 4224 insertions(+), 72 deletions(-)
>  create mode 100644 drivers/net/zxdh/zxdh_flow.c
>  create mode 100644 drivers/net/zxdh/zxdh_flow.h

Newer versions of Gcc complain about this intialization.

FAILED: drivers/libtmp_rte_net_zxdh.a.p/net_zxdh_zxdh_flow.c.o 
gcc -Idrivers/libtmp_rte_net_zxdh.a.p -Idrivers -I../drivers -Idrivers/net/zxdh -I../drivers/net/zxdh -Ilib/ethdev -I../lib/ethdev -Ilib/eal/common -I../lib/eal/common -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -I../kernel/linux -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -include rte_config.h -Wvla -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -fzero-init-padding-bits=all -D_GNU_SOURCE -fPIC -march=native -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -Wno-address-of-packed-member -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.zxdh -MD -MQ drivers/libtmp_rte_net_zxdh.a.p/net_zxdh_zxdh_flow.c.o -MF drivers/libtmp_rte_net_zxdh.a.p/net_zxdh_zxdh_flow.c.o.d -o drivers/libtmp_rte_net_zxdh.a.p/net_zxdh_zxdh_flow.c.o -c ../drivers/net/zxdh/zxdh_flow.c
../drivers/net/zxdh/zxdh_flow.c: In function ‘fd_flow_parse_pattern’:
../drivers/net/zxdh/zxdh_flow.c:1469:40: error: initializer-string for array of ‘unsigned char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (4 chars into 3 available) [-Werror=unterminated-string-initialization]
 1469 |                                 .vni = "\xff\xff\xff",
      |