From: Stephen Hemminger <stephen@networkplumber.org>
To: Bingbin Chen <chen.bingbin@zte.com.cn>
Cc: wang.junlong1@zte.com.cn, yang.yonggang@zte.com.cn, dev@dpdk.org
Subject: Re: [PATCH v1 1/2] net/zxdh: npsdk add flow director table ops
Date: Tue, 17 Jun 2025 07:07:08 -0700 [thread overview]
Message-ID: <20250617070708.10c146c2@hermes.local> (raw)
In-Reply-To: <20250617093225.3570498-1-chen.bingbin@zte.com.cn>
On Tue, 17 Jun 2025 17:32:25 +0800
Bingbin Chen <chen.bingbin@zte.com.cn> wrote:
> +static uint32_t
> +zxdh_np_agent_channel_acl_index_request(uint32_t dev_id,
> + uint32_t sdt_no,
> + uint32_t vport,
> + uint32_t *p_index)
> +{
> + uint32_t rc = ZXDH_OK;
Odd indentation here. Should either align, be nested or use one less tab.
static uint32_t
zxdh_np_agent_channel_acl_index_request(uint32_t dev_id,
uint32_t sdt_no,
uint32_t vport,
uint32_t *p_index)
{
OR
static uint32_t
zxdh_np_agent_channel_acl_index_request(uint32_t dev_id,
uint32_t sdt_no,
uint32_t vport,
uint32_t *p_index)
{
OR
static uint32_t
zxdh_np_agent_channel_acl_index_request(uint32_t dev_id, uint32_t sdt_no,
uint32_t vport, uint32_t *p_index)
{
next prev parent reply other threads:[~2025-06-17 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 9:31 [PATCH v1 0/2] add support flow director ops Bingbin Chen
2025-06-17 9:32 ` [PATCH v1 1/2] net/zxdh: npsdk add flow director table ops Bingbin Chen
2025-06-17 14:07 ` Stephen Hemminger [this message]
2025-06-17 14:08 ` Stephen Hemminger
2025-06-17 9:32 ` [PATCH v1 2/2] net/zxdh: add support flow director ops Bingbin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617070708.10c146c2@hermes.local \
--to=stephen@networkplumber.org \
--cc=chen.bingbin@zte.com.cn \
--cc=dev@dpdk.org \
--cc=wang.junlong1@zte.com.cn \
--cc=yang.yonggang@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).