From: Stephen Hemminger <stephen@networkplumber.org>
To: Junlong Wang <wang.junlong1@zte.com.cn>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation
Date: Tue, 17 Jun 2025 08:20:05 -0700 [thread overview]
Message-ID: <20250617082005.2977069a@hermes.local> (raw)
In-Reply-To: <20250617020503.3554511-1-wang.junlong1@zte.com.cn>
On Tue, 17 Jun 2025 10:04:59 +0800
Junlong Wang <wang.junlong1@zte.com.cn> wrote:
> fix meson.build issus in compilation, which
> caused the inability to compile in the arm64 environment.
>
> Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton")
> Cc: stable@dpdk.org
>
> Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
> ---
This series looks much better but please revise the commit message (again).
To help with stable (and user reports) it is better to include more
precise wording of what the problem is. It is clearer if you use the
word "fix" instead of "modify". Also, describe what the bug is.
This applies to several of these patches.
If it is a bug fix it could be marked for stable. Although this driver
is new and experimental so won't get backported.
Instead of:
Subject: net/zxdh: modify some MAC config issues
modify some mac config issues,
which were discovered during the testing process.
Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations")
Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
Something like:
Subject: net/zxdh: fix issues related to MAC configuration
Fix error handling when MAC configuration fails.
This is issue was discovered during internal testing.
Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations")
Cc: stable@dpdk.org
Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
prev parent reply other threads:[~2025-06-17 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 2:30 [PATCH v1 1/3] net/zxdh: modify some MAC config issues Junlong Wang
2025-06-07 2:30 ` [PATCH v1 2/3] net/zxdh: modify some VLAN related issues Junlong Wang
2025-06-16 16:20 ` Stephen Hemminger
2025-06-07 2:30 ` [PATCH v1 3/3] net/zxdh: modify RSS " Junlong Wang
2025-06-16 16:22 ` Stephen Hemminger
2025-06-12 0:14 ` [PATCH v1 1/3] net/zxdh: modify some MAC config issues Thomas Monjalon
2025-06-12 1:18 ` Junlong Wang
2025-06-16 16:16 ` Stephen Hemminger
2025-06-17 2:04 ` [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation Junlong Wang
2025-06-17 2:05 ` [PATCH v2 2/5] net/zxdh: modify some MAC config issues Junlong Wang
2025-06-17 2:05 ` [PATCH v2 3/5] net/zxdh: modify some VLAN related issues Junlong Wang
2025-06-17 2:05 ` [PATCH v2 4/5] net/zxdh: modify RSS " Junlong Wang
2025-06-17 2:05 ` [PATCH v2 5/5] net/zxdh: add support VLAN TPID set ops Junlong Wang
2025-06-17 3:32 ` zhoumin
2025-06-17 14:01 ` [PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation Stephen Hemminger
2025-06-17 15:20 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617082005.2977069a@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wang.junlong1@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).