From: Stephen Hemminger <stephen@networkplumber.org>
To: Maayan Kashani <mkashani@nvidia.com>
Cc: <dev@dpdk.org>, <dsosnowski@nvidia.com>, <rasland@nvidia.com>
Subject: Re: [PATCH 1/3] doc: gro API changes notice
Date: Tue, 17 Jun 2025 16:42:07 -0700 [thread overview]
Message-ID: <20250617164207.306e3124@hermes.local> (raw)
In-Reply-To: <20250617154255.190093-1-mkashani@nvidia.com>
On Tue, 17 Jun 2025 18:42:52 +0300
Maayan Kashani <mkashani@nvidia.com> wrote:
> when using --no-numa option,
> gro should be initiated with SOCKET_ID_ANY
> to allow using cross NUMA.
>
> API changes notice:
> Changed socket_id field in struct rte_gro_param from uint16 to
> int32 to support negative value -1 (== SOCKET_ID_ANY).
> Changed gro_tbl_create typedef to receive negative socket input.
>
> Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
GRO has experimental in the comments, but not the exported symbol
that was a mistake. It either is experimental or not. Given that
the tools check the exported symbol table, I would argue it is not
experimental now.
Most of the API's in ethdev use "unsigned int socket_id", I see no
reason for GRO to be different.
Why not use function versioning to do it now?
prev parent reply other threads:[~2025-06-17 23:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 15:42 Maayan Kashani
2025-06-17 15:42 ` [PATCH 2/3] gro: cross NUMA support Maayan Kashani
2025-06-17 15:42 ` [PATCH 3/3] app/testpmd: cross NUMA support for gro init Maayan Kashani
2025-06-17 23:42 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617164207.306e3124@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=rasland@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).