DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pravin Pathak <pravin.pathak@intel.com>
To: dev@dpdk.org
Cc: jerinj@marvell.com, mike.ximing.chen@intel.com,
	bruce.richardson@intel.com, thomas@monjalon.net,
	david.marchand@redhat.com, nipun.gupta@amd.com,
	chenbox@nvidia.com, tirthendu.sarkar@intel.com,
	Pravin Pathak <pravin.pathak@intel.com>,
	stable@dpdk.org
Subject: [PATCH v3 5/7] event/dlb2: fix to avoid credit release race condition
Date: Tue, 17 Jun 2025 13:26:28 -0500	[thread overview]
Message-ID: <20250617182631.257612-6-pravin.pathak@intel.com> (raw)
In-Reply-To: <20250617182631.257612-1-pravin.pathak@intel.com>

While unlinking ports, all associated credits should be released.
This commit avoids race condition when main thread is unlinking
while workers are running.

Fixes: a29248b57b31 ("event/dlb2: add port unlink and unlinks in progress")
Cc: stable@dpdk.org

Signed-off-by: Pravin Pathak <pravin.pathak@intel.com>
---
 drivers/event/dlb2/dlb2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 28c9054f63..6734e93eac 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -2664,7 +2664,7 @@ dlb2_eventdev_port_unlink(struct rte_eventdev *dev, void *event_port,
 		DLB2_LOG_LINE_DBG("dlb2: ignore unlink from dir port %d",
 			     ev_port->id);
 		rte_errno = 0;
-		return nb_unlinks; /* as if success */
+		goto ret_credits;
 	}
 
 	dlb2 = ev_port->dlb2;
-- 
2.39.1


  parent reply	other threads:[~2025-06-17 18:27 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09  4:23 [PATCH v1 0/7] event/dlb2: dlb2 hw resource management Pravin Pathak
2025-05-09  4:23 ` [PATCH v1 1/7] event/dlb2: addresses deq failure when CQ depth <= 16 Pravin Pathak
2025-05-09  4:23 ` [PATCH v1 2/7] event/dlb2: changes to correctly validate COS ID arguments Pravin Pathak
2025-05-09  4:23 ` [PATCH v1 3/7] event/dlb2: return 96 single link ports for DLB2.5 Pravin Pathak
2025-05-27  5:46   ` [EXTERNAL] " Jerin Jacob
2025-05-09  4:23 ` [PATCH v1 4/7] event/dlb2: support managing history list resource Pravin Pathak
2025-05-27  5:50   ` [EXTERNAL] " Jerin Jacob
2025-05-27  5:57   ` Jerin Jacob
2025-05-27 13:16     ` Thomas Monjalon
2025-05-09  4:23 ` [PATCH v1 5/7] event/dlb2: avoid credit release race condition Pravin Pathak
2025-05-09  4:24 ` [PATCH v1 6/7] event/dlb2: update qid depth xstat in vector path Pravin Pathak
2025-05-09  4:24 ` [PATCH v1 7/7] event/dlb2: fix default credits in dlb2_eventdev_info_get() Pravin Pathak
2025-06-03 18:05 ` [PATCH v2 0/7] event/dlb2: dlb2 hw resource management Pravin Pathak
2025-06-03 18:05   ` [PATCH v2 1/7] event/dlb2: addresses deq failure when CQ depth <= 16 Pravin Pathak
2025-06-04  8:58     ` Jerin Jacob
2025-06-03 18:05   ` [PATCH v2 2/7] event/dlb2: changes to correctly validate COS ID arguments Pravin Pathak
2025-06-03 18:05   ` [PATCH v2 3/7] event/dlb2: return 96 single link ports for DLB2.5 Pravin Pathak
2025-06-03 18:05   ` [PATCH v2 4/7] event/dlb2: support managing history list resource Pravin Pathak
2025-06-03 18:05   ` [PATCH v2 5/7] event/dlb2: avoid credit release race condition Pravin Pathak
2025-06-03 18:05   ` [PATCH v2 6/7] event/dlb2: update qid depth xstat in vector path Pravin Pathak
2025-06-03 18:05   ` [PATCH v2 7/7] event/dlb2: return default credits based on HW version Pravin Pathak
2025-06-17 18:26 ` [PATCH v3 0/7] event/dlb2: dlb2 hw resource management Pravin Pathak
2025-06-17 18:26   ` [PATCH v3 1/7] event/dlb2: fix addresses deq failure when CQ depth <= 16 Pravin Pathak
2025-06-17 18:26   ` [PATCH v3 2/7] event/dlb2: fix validaton of LDB port COS ID arguments Pravin Pathak
2025-06-17 18:26   ` [PATCH v3 3/7] event/dlb2: fix num single link ports for DLB2.5 Pravin Pathak
2025-06-17 18:26   ` [PATCH v3 4/7] event/dlb2: support managing history list resource Pravin Pathak
2025-06-17 18:26   ` Pravin Pathak [this message]
2025-06-17 18:26   ` [PATCH v3 6/7] event/dlb2: fix qid depth xstat in vector path Pravin Pathak
2025-06-17 18:26   ` [PATCH v3 7/7] event/dlb2: fix default credits based on HW version Pravin Pathak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250617182631.257612-6-pravin.pathak@intel.com \
    --to=pravin.pathak@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=chenbox@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mike.ximing.chen@intel.com \
    --cc=nipun.gupta@amd.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=tirthendu.sarkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).