From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
To: Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <gakhil@marvell.com>,
Volodymyr Fialko <vfialko@marvell.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>, <ndabilpuram@marvell.com>,
"Rakesh Kudurumalla" <rkudurumalla@marvell.com>
Subject: [PATCH v2 1/1] examples/ipsec-secgw: resolve segfault for IPsec packets
Date: Wed, 18 Jun 2025 14:00:06 +0530 [thread overview]
Message-ID: <20250618083006.1679656-1-rkudurumalla@marvell.com> (raw)
In-Reply-To: <20250407072155.1255817-1-rkudurumalla@marvell.com>
launching ipsec-segw application in event vector mode
after traffic has started results in segfault because
we are receiving few IPSEC packet and application is trying
to decrypt IPSEC packets using lookaside protocol.
This contradicts inline event mode.This patch fixes the same
by freeing IPSEC packets and processing only plain packets.
Fixes: 1d5078c6cf19 ("examples/ipsec-secgw: support event vector in lookaside mode")
Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
V2: Add fixes tag
examples/ipsec-secgw/ipsec_worker.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c
index e0690fc8d9..04609964cd 100644
--- a/examples/ipsec-secgw/ipsec_worker.c
+++ b/examples/ipsec-secgw/ipsec_worker.c
@@ -700,6 +700,9 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec,
struct rte_ipsec_session *sess;
struct rte_mbuf *pkt;
struct ipsec_sa *sa;
+ uint8_t mask = (1UL << RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO) |
+ (1UL << RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL);
+
j = ipsec_ev_route_ip_pkts(vec, rt, t);
@@ -707,7 +710,7 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec,
for (i = 0; i < t->ipsec.num; i++) {
pkt = t->ipsec.pkts[i];
sa = ipsec_mask_saptr(t->ipsec.saptr[i]);
- if (unlikely(sa == NULL)) {
+ if (unlikely(sa == NULL) || ((1UL << sa->sessions[0].type) & mask)) {
free_pkts(&pkt, 1);
continue;
}
--
2.25.1
prev parent reply other threads:[~2025-06-18 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:21 [PATCH " Rakesh Kudurumalla
2025-05-21 14:13 ` Akhil Goyal
2025-06-18 8:30 ` Rakesh Kudurumalla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618083006.1679656-1-rkudurumalla@marvell.com \
--to=rkudurumalla@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).