From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Gage Eads <gage.eads@intel.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: [PATCH 09/10] stack: fix unaligned accesses on 128-bit
Date: Thu, 19 Jun 2025 09:10:35 +0200 [thread overview]
Message-ID: <20250619071037.37325-10-david.marchand@redhat.com> (raw)
In-Reply-To: <20250619071037.37325-1-david.marchand@redhat.com>
Caught by UBSan:
../lib/eal/x86/include/rte_atomic_64.h:206:21: runtime error:
member access within misaligned address 0x7ffd9c67f228 for
type 'const rte_int128_t', which requires 16 byte alignment
0x7ffd9c67f228: note: pointer points here
00 00 00 00 c0 5d 3e 00 01 00 00 00 01 00 00 00 00 00 00 00
^
00 00 00 00 00 00 00 00 00 00 00 00
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../lib/eal/x86/include/rte_atomic_64.h:206:21 in
../lib/eal/x86/include/rte_atomic_64.h:206:21: runtime error:
member access within misaligned address 0x7ffd9c67f228 for type
'const union rte_int128_t::(anonymous at
../lib/eal/include/generic/rte_atomic.h:1102:2)', which requires
16 byte alignment
0x7ffd9c67f228: note: pointer points here
00 00 00 00 c0 5d 3e 00 01 00 00 00 01 00 00 00 00 00 00 00
^
00 00 00 00 00 00 00 00 00 00 00 00
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../lib/eal/x86/include/rte_atomic_64.h:206:21 in
../lib/eal/x86/include/rte_atomic_64.h:206:16: runtime error:
load of misaligned address 0x7ffd9c67f228 for type
'const uint64_t' (aka 'const unsigned long'), which requires
16 byte alignment
0x7ffd9c67f228: note: pointer points here
00 00 00 00 c0 5d 3e 00 01 00 00 00 01 00 00 00 00 00 00 00
^
00 00 00 00 00 00 00 00 00 00 00 00
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../lib/eal/x86/include/rte_atomic_64.h:206:21 in
Fixes: 3340202f5954 ("stack: add lock-free implementation")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/stack/rte_stack_lf_c11.h | 8 ++++----
lib/stack/rte_stack_lf_generic.h | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/stack/rte_stack_lf_c11.h b/lib/stack/rte_stack_lf_c11.h
index b97e02d6a1..f674731235 100644
--- a/lib/stack/rte_stack_lf_c11.h
+++ b/lib/stack/rte_stack_lf_c11.h
@@ -63,13 +63,13 @@ __rte_stack_lf_push_elems(struct rte_stack_lf_list *list,
struct rte_stack_lf_elem *last,
unsigned int num)
{
- struct rte_stack_lf_head old_head;
+ alignas(16) struct rte_stack_lf_head old_head;
int success;
old_head = list->head;
do {
- struct rte_stack_lf_head new_head;
+ alignas(16) struct rte_stack_lf_head new_head;
/* Swing the top pointer to the first element in the list and
* make the last element point to the old top.
@@ -102,7 +102,7 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,
void **obj_table,
struct rte_stack_lf_elem **last)
{
- struct rte_stack_lf_head old_head;
+ alignas(16) struct rte_stack_lf_head old_head;
uint64_t len;
int success = 0;
@@ -129,7 +129,7 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,
/* Pop num elements */
do {
- struct rte_stack_lf_head new_head;
+ alignas(16) struct rte_stack_lf_head new_head;
struct rte_stack_lf_elem *tmp;
unsigned int i;
diff --git a/lib/stack/rte_stack_lf_generic.h b/lib/stack/rte_stack_lf_generic.h
index cc69e4d168..32f56dffdd 100644
--- a/lib/stack/rte_stack_lf_generic.h
+++ b/lib/stack/rte_stack_lf_generic.h
@@ -36,13 +36,13 @@ __rte_stack_lf_push_elems(struct rte_stack_lf_list *list,
struct rte_stack_lf_elem *last,
unsigned int num)
{
- struct rte_stack_lf_head old_head;
+ alignas(16) struct rte_stack_lf_head old_head;
int success;
old_head = list->head;
do {
- struct rte_stack_lf_head new_head;
+ alignas(16) struct rte_stack_lf_head new_head;
/* An acquire fence (or stronger) is needed for weak memory
* models to establish a synchronized-with relationship between
@@ -77,7 +77,7 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,
void **obj_table,
struct rte_stack_lf_elem **last)
{
- struct rte_stack_lf_head old_head;
+ alignas(16) struct rte_stack_lf_head old_head;
int success = 0;
/* Reserve num elements, if available */
@@ -99,7 +99,7 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,
/* Pop num elements */
do {
- struct rte_stack_lf_head new_head;
+ alignas(16) struct rte_stack_lf_head new_head;
struct rte_stack_lf_elem *tmp;
unsigned int i;
--
2.49.0
next prev parent reply other threads:[~2025-06-19 7:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 7:10 [PATCH 00/10] Run with UBSan in GHA David Marchand
2025-06-19 7:10 ` [PATCH 01/10] ci: save ccache on failure David Marchand
2025-06-19 7:10 ` [PATCH 02/10] test/telemetry: fix test calling all commands David Marchand
2025-06-19 7:10 ` [PATCH 03/10] test/mempool: fix test without stack driver David Marchand
2025-06-19 7:10 ` [PATCH 04/10] eal: fix plugin dir walk David Marchand
2025-06-19 7:10 ` [PATCH 05/10] cmdline: fix port list parsing David Marchand
2025-06-19 7:10 ` [PATCH 06/10] cmdline: fix highest bit " David Marchand
2025-06-19 7:10 ` [PATCH 07/10] tailq: fix cast macro for null pointer David Marchand
2025-06-19 7:10 ` [PATCH 08/10] hash: fix unaligned access in predictable RSS David Marchand
2025-06-19 7:10 ` David Marchand [this message]
2025-06-19 7:10 ` [PATCH 10/10] build: support Undefined Behavior Sanitizer David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250619071037.37325-10-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).