From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC03146A37; Mon, 23 Jun 2025 15:53:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4695540696; Mon, 23 Jun 2025 15:53:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B7BBE40674 for ; Mon, 23 Jun 2025 15:53:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750686802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hH0b6/b4NVaha2vNM3GgI/X/RQ1XAAiznlb6Z86RvHA=; b=SNnKajgy91mh1TLGnMERcyn31g2OqRshiA77n9CtpZRDWQ4E4g76nBTo/ibcTeW5e76Cjw Ue9VJpQCZgZ2xRYv2AK+jVZ2gjsUYhWbU99Dk3nXUo4UabfDFyiCXv8TlgxWj/SQY7ra1F qxttvtJDWLedOvYvf9RKOGcgBm13teM= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-Jn90EYHJPO-LCJvwq5D4nw-1; Mon, 23 Jun 2025 09:53:19 -0400 X-MC-Unique: Jn90EYHJPO-LCJvwq5D4nw-1 X-Mimecast-MFC-AGG-ID: Jn90EYHJPO-LCJvwq5D4nw_1750686798 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D0AE6180120B; Mon, 23 Jun 2025 13:53:17 +0000 (UTC) Received: from dmarchan.lan (unknown [10.44.32.240]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5D06319560B3; Mon, 23 Jun 2025 13:53:16 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Bruce Richardson Subject: [PATCH v2 06/10] cmdline: fix highest bit port list parsing Date: Mon, 23 Jun 2025 15:52:36 +0200 Message-ID: <20250623135242.461965-7-david.marchand@redhat.com> In-Reply-To: <20250623135242.461965-1-david.marchand@redhat.com> References: <20250619071037.37325-1-david.marchand@redhat.com> <20250623135242.461965-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: o7P9QKZXtCLpHZQ-A5Eui9iMnOIB4p4FXCHSeF7MglY_1750686798 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org pl->map is a uint32_t. Caught by UBSan: ../lib/cmdline/cmdline_parse_portlist.c:27:17: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../lib/cmdline/cmdline_parse_portlist.c:27:17 in Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Bruce Richardson --- Changes since v1: - moved variable increment out of the macro call, --- lib/cmdline/cmdline_parse_portlist.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/cmdline/cmdline_parse_portlist.c b/lib/cmdline/cmdline_parse_portlist.c index 549f6d9671..3efe4143e3 100644 --- a/lib/cmdline/cmdline_parse_portlist.c +++ b/lib/cmdline/cmdline_parse_portlist.c @@ -10,7 +10,9 @@ #include #include +#include #include + #include "cmdline_parse.h" #include "cmdline_parse_portlist.h" @@ -26,7 +28,8 @@ static void parse_set_list(cmdline_portlist_t *pl, size_t low, size_t high) { do { - pl->map |= (1 << low++); + pl->map |= RTE_BIT32(low); + low++; } while (low <= high); } -- 2.49.0